rework sysvars to byte arrays and accessors

Author: rustopian

epoch-schedule/src/lib.rs

@@ -295,7 +295,7 @@ mod tests {
 
     #[test]
     fn test_clone() {
-        let epoch_schedule = EpochSchedule::custom(1, 2, true);
+        let epoch_schedule = EpochSchedule::custom(MINIMUM_SLOTS_PER_EPOCH, MINIMUM_SLOTS_PER_EPOCH, true);
         #[allow(clippy::clone_on_copy)]
         let cloned_epoch_schedule = epoch_schedule.clone();
         assert_eq!(cloned_epoch_schedule, epoch_schedule);

genesis-config/src/lib.rs

@@ -244,8 +244,8 @@ impl fmt::Display for GenesisConfig {
             self.ticks_per_slot,
             self.poh_config.hashes_per_tick,
             self.poh_config.target_tick_duration,
-            self.epoch_schedule.slots_per_epoch,
-            if self.epoch_schedule.warmup {
+            self.epoch_schedule.slots_per_epoch(),
+            if self.epoch_schedule.warmup() {
                 "en"
             } else {
                 "dis"

rent/src/lib.rs

@@ -81,10 +81,6 @@ impl Default for Rent {
 }
 
 impl Rent {
-    /// Calculate how much rent to burn from the collected rent.
-    ///
-    /// The first value returned is the amount burned. The second is the amount
-    /// to distribute to validators.
     pub fn lamports_per_byte_year(&self) -> u64 {
         u64::from_le_bytes(self.lamports_per_byte_year)
     }
@@ -105,6 +101,10 @@ impl Rent {
         }
     }
 
+    /// Calculate how much rent to burn from the collected rent.
+    ///
+    /// The first value returned is the amount burned. The second is the amount
+    /// to distribute to validators.
     pub fn calculate_burn(&self, rent_collected: u64) -> (u64, u64) {
         let burned_portion = (rent_collected * u64::from(self.burn_percent)) / 100;
         (burned_portion, rent_collected - burned_portion)

sysvar/src/epoch_rewards.rs

@@ -47,15 +47,10 @@
 //! }
 //! #
 //! # use solana_sysvar_id::SysvarId;
+//! # use solana_hash::Hash;
 //! # let p = EpochRewards::id();
 //! # let l = &mut 1559040;
-//! # let epoch_rewards = EpochRewards {
-//! #     distribution_starting_block_height: 42,
-//! #     total_rewards: 100,
-//! #     distributed_rewards: 10,
-//! #     active: true,
-//! #     ..EpochRewards::default()
-//! # };
+//! # let epoch_rewards = EpochRewards::new(42, 0, Hash::default(), 0, 100, 10, true);
 //! # let mut d: Vec<u8> = bincode::serialize(&epoch_rewards).unwrap();
 //! # let a = AccountInfo::new(&p, false, false, l, &mut d, &p, false);
 //! # let accounts = &[a.clone(), a];
@@ -95,15 +90,10 @@
 //! }
 //! #
 //! # use solana_sysvar_id::SysvarId;
+//! # use solana_hash::Hash;
 //! # let p = EpochRewards::id();
 //! # let l = &mut 1559040;
-//! # let epoch_rewards = EpochRewards {
-//! #     distribution_starting_block_height: 42,
-//! #     total_rewards: 100,
-//! #     distributed_rewards: 10,
-//! #     active: true,
-//! #     ..EpochRewards::default()
-//! # };
+//! # let epoch_rewards = EpochRewards::new(42, 0, Hash::default(), 0, 100, 10, true);
 //! # let mut d: Vec<u8> = bincode::serialize(&epoch_rewards).unwrap();
 //! # let a = AccountInfo::new(&p, false, false, l, &mut d, &p, false);
 //! # let accounts = &[a.clone(), a];
@@ -127,13 +117,8 @@
 //! # use anyhow::Result;
 //! #
 //! fn print_sysvar_epoch_rewards(client: &RpcClient) -> Result<()> {
-//! #   let epoch_rewards = EpochRewards {
-//! #       distribution_starting_block_height: 42,
-//! #       total_rewards: 100,
-//! #       distributed_rewards: 10,
-//! #       active: true,
-//! #       ..EpochRewards::default()
-//! #   };
+//! #   use solana_hash::Hash;
+//! #   let epoch_rewards = EpochRewards::new(42, 0, Hash::default(), 0, 100, 10, true);
 //! #   let data: Vec<u8> = bincode::serialize(&epoch_rewards)?;
 //! #   client.set_get_account_response(epoch_rewards::ID, Account {
 //! #       lamports: 1120560,