Create compose function for AccountSharedData
#456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to remove
fn createfromWritableAccount, because the new account format for SVM has only references and does not allow one to create it from owned values, like the function in the trait.I tracked all monorepo usages, and found that
createis only used forAccountSharedData. There is a single usage forstruct Account, but all its fields are public, so we can create it directly. See LucasSte/agave@224a93eSolution
Create
fn composeinimpl AccountSharedDatato replacefn create.