Skip to content

Commit b7162d5

Browse files
juliannageleaokblast
authored andcommitted
[X86] Update test to not iterate past array boundaries. (llvm#163991)
This test has loop iterating past (`61`) the array boundaries (`58`). So far this didn't seem to matter, but recently with this change llvm#155253 the constraint elimination in swift has been able to figure this out and is transforming the loop into an infinite one like this ``` *** IR Dump After ConstraintEliminationPass on test_known_trip_count *** define void @test_known_trip_count() local_unnamed_addr { entry: br label %for.body for.body: ; preds = %entry, %for.body %indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ] %arrayidx = getelementptr inbounds nuw double, ptr @b, i64 %indvars.iv %0 = load double, ptr %arrayidx, align 8 %arrayidx2 = getelementptr inbounds nuw double, ptr @c, i64 %indvars.iv %1 = load double, ptr %arrayidx2, align 8 %add = fadd double %0, %1 %arrayidx4 = getelementptr inbounds nuw double, ptr @A, i64 %indvars.iv store double %add, ptr %arrayidx4, align 8 %indvars.iv.next = add nuw nsw i64 %indvars.iv, 1 br i1 false, label %exit, label %for.body exit: ; preds = %for.body ret void }% ``` causing the test to fail. This is trying to address the root cause here.
1 parent 873cdc2 commit b7162d5

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

llvm/test/Transforms/PhaseOrdering/X86/excessive-unrolling.ll

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -124,26 +124,22 @@ define void @test_known_trip_count() {
124124
; CHECK-NEXT: [[TMP27:%.*]] = fadd <2 x double> [[WIDE_LOAD3_13]], [[WIDE_LOAD5_13]]
125125
; CHECK-NEXT: store <2 x double> [[TMP26]], ptr getelementptr inbounds nuw (i8, ptr @a, i64 416), align 16
126126
; CHECK-NEXT: store <2 x double> [[TMP27]], ptr getelementptr inbounds nuw (i8, ptr @a, i64 432), align 16
127-
; CHECK-NEXT: [[WIDE_LOAD_14:%.*]] = load <2 x double>, ptr getelementptr inbounds nuw (i8, ptr @b, i64 448), align 16
128-
; CHECK-NEXT: [[WIDE_LOAD3_14:%.*]] = load <2 x double>, ptr getelementptr inbounds nuw (i8, ptr @b, i64 464), align 16
129-
; CHECK-NEXT: [[WIDE_LOAD4_14:%.*]] = load <2 x double>, ptr getelementptr inbounds nuw (i8, ptr @c, i64 448), align 16
130-
; CHECK-NEXT: [[WIDE_LOAD5_14:%.*]] = load <2 x double>, ptr getelementptr inbounds nuw (i8, ptr @c, i64 464), align 16
131-
; CHECK-NEXT: [[TMP28:%.*]] = fadd <2 x double> [[WIDE_LOAD_14]], [[WIDE_LOAD4_14]]
132-
; CHECK-NEXT: [[TMP29:%.*]] = fadd <2 x double> [[WIDE_LOAD3_14]], [[WIDE_LOAD5_14]]
133-
; CHECK-NEXT: store <2 x double> [[TMP28]], ptr getelementptr inbounds nuw (i8, ptr @a, i64 448), align 16
134-
; CHECK-NEXT: store <2 x double> [[TMP29]], ptr getelementptr inbounds nuw (i8, ptr @a, i64 464), align 16
135-
; CHECK-NEXT: [[TMP30:%.*]] = load double, ptr getelementptr inbounds nuw (i8, ptr @b, i64 480), align 16
136-
; CHECK-NEXT: [[TMP31:%.*]] = load double, ptr getelementptr inbounds nuw (i8, ptr @c, i64 480), align 16
127+
; CHECK-NEXT: [[TMP30:%.*]] = load double, ptr getelementptr inbounds nuw (i8, ptr @b, i64 448), align 16
128+
; CHECK-NEXT: [[TMP31:%.*]] = load double, ptr getelementptr inbounds nuw (i8, ptr @c, i64 448), align 16
137129
; CHECK-NEXT: [[ADD:%.*]] = fadd double [[TMP30]], [[TMP31]]
138-
; CHECK-NEXT: store double [[ADD]], ptr getelementptr inbounds nuw (i8, ptr @a, i64 480), align 16
130+
; CHECK-NEXT: store double [[ADD]], ptr getelementptr inbounds nuw (i8, ptr @a, i64 448), align 16
131+
; CHECK-NEXT: [[TMP32:%.*]] = load double, ptr getelementptr inbounds nuw (i8, ptr @b, i64 456), align 8
132+
; CHECK-NEXT: [[TMP33:%.*]] = load double, ptr getelementptr inbounds nuw (i8, ptr @c, i64 456), align 8
133+
; CHECK-NEXT: [[ADD_1:%.*]] = fadd double [[TMP32]], [[TMP33]]
134+
; CHECK-NEXT: store double [[ADD_1]], ptr getelementptr inbounds nuw (i8, ptr @a, i64 456), align 8
139135
; CHECK-NEXT: ret void
140136
;
141137
entry:
142138
br label %for.cond
143139

144140
for.cond:
145141
%i.0 = phi i32 [ 0, %entry ], [ %inc, %for.body ]
146-
%cmp = icmp slt i32 %i.0, 61
142+
%cmp = icmp slt i32 %i.0, 58
147143
br i1 %cmp, label %for.body, label %exit
148144

149145
for.body:

0 commit comments

Comments
 (0)