Skip to content

Commit eb7ce42

Browse files
maksleventalaokblast
authored andcommitted
[MLIR][ExecutionEngine] don't leak -Wweak-vtables (llvm#164498)
I'm not 100% what this is used for in this lib but the compile flag leaks out and prevents (in certain compile scenarios) linking `mlir_c_runner_utils`.
1 parent 0cdb911 commit eb7ce42

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mlir/lib/ExecutionEngine/SparseTensor/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ set_property(TARGET MLIRSparseTensorRuntime PROPERTY CXX_STANDARD 17)
2121
check_cxx_compiler_flag(-Wweak-vtables
2222
COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
2323
if(COMPILER_SUPPORTS_WARNING_WEAK_VTABLES)
24-
target_compile_options(MLIRSparseTensorRuntime PUBLIC
24+
target_compile_options(MLIRSparseTensorRuntime PRIVATE
2525
"-Wweak-vtables")
2626
endif()

0 commit comments

Comments
 (0)