Skip to content

Commit 610ff03

Browse files
committed
Fix children of AbstractConfigureStateTrigger not getting tracked correctly (requires Everest 1.5473 or later + .NET 8)
1 parent c8864c1 commit 610ff03

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

everest.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
- Name: CommunalHelper
2-
Version: 1.23.0
2+
Version: 0.0.0-dev
33
DLL: src/bin/Debug/net7.0/CommunalHelper.dll
44
Dependencies:
55
- Name: EverestCore
6-
Version: 1.5184.0
6+
Version: 1.5474.0 # latest beta as of writing, todo: remember to update this when it hits stable!

src/CommunalHelper.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<Project Sdk="Microsoft.NET.Sdk">
44
<PropertyGroup>
5-
<TargetFrameworks>net7.0</TargetFrameworks>
5+
<TargetFrameworks>net8.0</TargetFrameworks>
66
<AssemblyName>CommunalHelper</AssemblyName>
77
<RootNamespace>Celeste.Mod.CommunalHelper</RootNamespace>
88
<LangVersion>latest</LangVersion>

src/Triggers/AbstractConfigureStateTrigger.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33

44
namespace Celeste.Mod.CommunalHelper.Triggers;
55

6-
// todo: tracking is borked
6+
// unfortunately, due to this class being generic, `[Tracked(true)]` doesn't really do anything here. we include it anyway as it signifies our intent
7+
// all children of this class need to be marked as `[TrackedAs(typeof(AbstractConfigureStateTrigger<TOptions, TChanges>))]` in order to be tracked properly
78
[Tracked(true)]
89
public abstract class AbstractConfigureStateTrigger<TOptions, TChanges> : Trigger
910
where TOptions : struct where TChanges : struct

0 commit comments

Comments
 (0)