Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit 3d4918e

Browse files
Sharjeel-KhanGerrit Code Review
authored andcommitted
Revert "bionic: Disable arm32 cpu_target_featuers test"
This reverts commit 3b3b356. Reason for revert: This test was disabled because it was failing on arm32 due to a bad hardcoding. We fixed the hardcoding in llvm/llvm-project#122969 and cherry-picked it in aosp/3453341 so the change is in clang-r547379. We can revert this CL and re-enable the test. Bug: 369186774 Change-Id: I2cf8ec2ef25fdea134ce8e39c5fdba34c04fc524 Test: Presubmit
1 parent 3b3b356 commit 3d4918e

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

tests/cpu_target_features_test.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,15 @@ TEST(cpu_target_features, has_expected_aarch64_compiler_values) {
5454
GTEST_SKIP() << "Not targeting an aarch64 architecture.";
5555
#endif
5656
}
57+
58+
TEST(cpu_target_features, has_expected_arm_compiler_values) {
59+
#if defined(__arm__)
60+
ExecTestHelper eth;
61+
char* const argv[] = {nullptr};
62+
const auto invocation = [&] { execvp("cpu-target-features", argv); };
63+
eth.Run(invocation, 0, "(^|\n)__ARM_FEATURE_AES=1($|\n)");
64+
eth.Run(invocation, 0, "(^|\n)__ARM_FEATURE_CRC32=1($|\n)");
65+
#else
66+
GTEST_SKIP() << "Not targeting an arm architecture.";
67+
#endif
68+
}

0 commit comments

Comments
 (0)