Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Commit df67242

Browse files
committed
Remove clang workaround.
https://reviews.llvm.org/D58531 remains open, but allegedly (from the comments on that change) https://reviews.llvm.org/D58091 made it no longer matter... Change-Id: If7c1e6aa51eccf9bfea6a06278ddb556a2de4396
1 parent 75237ed commit df67242

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

libc/include/pthread.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -144,20 +144,7 @@ int pthread_cond_timedwait_monotonic_np(pthread_cond_t* _Nonnull __cond, pthread
144144
const struct timespec* _Nullable __timeout) __INTRODUCED_IN_64(28);
145145
int pthread_cond_wait(pthread_cond_t* _Nonnull __cond, pthread_mutex_t* _Nonnull __mutex);
146146

147-
#if defined(__clang__)
148-
/*
149-
* Disable -Wbuiltin-requires-header because clang confuses this declaration with the one defined in
150-
* "llvm/tools/clang/include/clang/Basic/Builtins.def", which did not define any formal arguments.
151-
* It seems to be an upstream bug and the fix (https://reviews.llvm.org/D58531) is still under
152-
* review. Thus, let's disable the warning for this function declaration.
153-
*/
154-
#pragma clang diagnostic push
155-
#pragma clang diagnostic ignored "-Wbuiltin-requires-header"
156-
#endif
157147
int pthread_create(pthread_t* _Nonnull __pthread_ptr, pthread_attr_t const* _Nullable __attr, void* _Nonnull (* _Nonnull __start_routine)(void* _Nonnull), void* _Nullable);
158-
#if defined(__clang__)
159-
#pragma clang diagnostic pop
160-
#endif
161148

162149
int pthread_detach(pthread_t __pthread);
163150
void pthread_exit(void* _Nullable __return_value) __noreturn;

0 commit comments

Comments
 (0)