Merge pull request #250 from ap--/fix-lazy-exception-2

fix via common base class

Author: ap--

src/seabreeze/_exc.py

@@ -0,0 +1,2 @@
+class SeaBreezeError(Exception):
+    pass

src/seabreeze/cseabreeze/c_seabreeze_wrapper.pyx

@@ -16,6 +16,8 @@ from collections import namedtuple
 
 import numpy as np
 
+from seabreeze._exc import SeaBreezeError as _SeaBreezeError
+
 
 # from libseabreeze api/SeaBreezeConstants.h
 class _ErrorCode(object):
@@ -58,7 +60,7 @@ SpectrumMetadata = namedtuple(
 
 # DO NOT DIRECTLY IMPORT EXCEPTIONS FROM HERE!
 # ALWAYS IMPORT FROM `seabreeze.spectrometers`
-class SeaBreezeError(Exception):
+class SeaBreezeError(_SeaBreezeError):
 
     _error_msgs = (
         "Success",

src/seabreeze/pyseabreeze/exceptions.py

@@ -2,10 +2,13 @@
 
 # DO NOT DIRECTLY IMPORT EXCEPTIONS FROM HERE!
 # ALWAYS IMPORT FROM `seabreeze.spectrometers`
+from seabreeze._exc import SeaBreezeError as SeaBreezeError
 
-
-class SeaBreezeError(Exception):
-    """SeaBreezeError base class"""
+__all__ = [
+    "SeaBreezeError",
+    "SeaBreezeNumFeaturesError",
+    "SeaBreezeNotSupported",
+]
 
 
 class SeaBreezeNumFeaturesError(SeaBreezeError):

src/seabreeze/spectrometers.py

@@ -9,13 +9,12 @@
 
 from __future__ import annotations
 
-import operator
-import sys
 from typing import TYPE_CHECKING
 
 import numpy
 
 import seabreeze.backends
+from seabreeze._exc import SeaBreezeError
 from seabreeze.types import SeaBreezeAPI
 from seabreeze.types import SeaBreezeBackend
 from seabreeze.types import SeaBreezeFeatureAccessor
@@ -38,26 +37,6 @@ def __dir__() -> list[str]:
     return __all__
 
 
-def _load_seabreeze_error_cls() -> type[SeaBreezeError]:
-    # lazy load the SeaBreezeException
-    cls = operator.attrgetter("_lib.SeaBreezeError")(sys.modules[__name__])
-    globals()["SeaBreezeError"] = cls
-    return cls  # type: ignore[no-any-return]
-
-
-class _LazyMeta(type):
-    def __instancecheck__(cls, instance: object) -> bool:
-        return isinstance(instance, _load_seabreeze_error_cls())
-
-    def __subclasscheck__(cls, __subclass: type) -> bool:
-        return issubclass(__subclass, _load_seabreeze_error_cls())
-
-
-class SeaBreezeError(Exception, metaclass=_LazyMeta):
-    def __new__(cls, *args: str) -> SeaBreezeError:
-        return _load_seabreeze_error_cls()(*args)
-
-
 # get the backend and add some functions/classes to this module
 _lib: SeaBreezeBackend