Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Commit 292a37f

Browse files
ajbozarthsrowen
authored andcommitted
[SPARK-18816][WEB UI] Executors Logs column only ran visibility check on initial table load
## What changes were proposed in this pull request? When I added a visibility check for the logs column on the executors page in apache#14382 the method I used only ran the check on the initial DataTable creation and not subsequent page loads. I moved the check out of the table definition and instead it runs on each page load. The jQuery DataTable functionality used is the same. ## How was this patch tested? Tested Manually No visible UI changes to screenshot. Author: Alex Bozarth <[email protected]> Closes apache#16256 from ajbozarth/spark18816. (cherry picked from commit aebf44e) Signed-off-by: Sean Owen <[email protected]>
1 parent d5c4a5d commit 292a37f

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

core/src/main/resources/org/apache/spark/ui/static/executorspage.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -411,10 +411,6 @@ $(document).ready(function () {
411411
}
412412
],
413413
"columnDefs": [
414-
{
415-
"targets": [ 15 ],
416-
"visible": logsExist(response)
417-
},
418414
{
419415
"targets": [ 16 ],
420416
"visible": getThreadDumpEnabled()
@@ -423,7 +419,8 @@ $(document).ready(function () {
423419
"order": [[0, "asc"]]
424420
};
425421

426-
$(selector).DataTable(conf);
422+
var dt = $(selector).DataTable(conf);
423+
dt.column(15).visible(logsExist(response));
427424
$('#active-executors [data-toggle="tooltip"]').tooltip();
428425

429426
var sumSelector = "#summary-execs-table";

0 commit comments

Comments
 (0)