Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Commit 9be8f20

Browse files
mccheahash211
authored andcommitted
Use tini in Docker images (#320)
1 parent 0702e18 commit 9be8f20

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

resource-managers/kubernetes/docker-minimal-bundle/src/main/docker/driver/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ FROM openjdk:8-alpine
2222
# docker build -t spark-driver:latest -f dockerfiles/driver/Dockerfile .
2323

2424
RUN apk upgrade --update
25-
RUN apk add --update bash
25+
RUN apk add --update bash tini
2626
RUN mkdir -p /opt/spark
2727
RUN touch /opt/spark/RELEASE
2828

@@ -41,4 +41,4 @@ CMD SPARK_CLASSPATH="${SPARK_HOME}/jars/*" && \
4141
if ! [ -z ${SPARK_SUBMIT_EXTRA_CLASSPATH+x} ]; then SPARK_CLASSPATH="$SPARK_SUBMIT_EXTRA_CLASSPATH:$SPARK_CLASSPATH"; fi && \
4242
if ! [ -z ${SPARK_EXTRA_CLASSPATH+x} ]; then SPARK_CLASSPATH="$SPARK_EXTRA_CLASSPATH:$SPARK_CLASSPATH"; fi && \
4343
if ! [ -z ${SPARK_MOUNTED_FILES_DIR} ]; then cp -R "$SPARK_MOUNTED_FILES_DIR/." .; fi && \
44-
exec ${JAVA_HOME}/bin/java $SPARK_DRIVER_JAVA_OPTS -cp $SPARK_CLASSPATH -Xms$SPARK_DRIVER_MEMORY -Xmx$SPARK_DRIVER_MEMORY $SPARK_DRIVER_CLASS $SPARK_DRIVER_ARGS
44+
exec /sbin/tini -- ${JAVA_HOME}/bin/java $SPARK_DRIVER_JAVA_OPTS -cp $SPARK_CLASSPATH -Xms$SPARK_DRIVER_MEMORY -Xmx$SPARK_DRIVER_MEMORY $SPARK_DRIVER_CLASS $SPARK_DRIVER_ARGS

resource-managers/kubernetes/docker-minimal-bundle/src/main/docker/executor/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ FROM openjdk:8-alpine
2222
# docker build -t spark-executor:latest -f dockerfiles/executor/Dockerfile .
2323

2424
RUN apk upgrade --update
25-
RUN apk add --update bash
25+
RUN apk add --update bash tini
2626
RUN mkdir -p /opt/spark
2727
RUN touch /opt/spark/RELEASE
2828

@@ -41,4 +41,4 @@ CMD SPARK_CLASSPATH="${SPARK_HOME}/jars/*" && \
4141
if ! [ -z ${SPARK_MOUNTED_CLASSPATH}+x} ]; then SPARK_CLASSPATH="$SPARK_MOUNTED_CLASSPATH:$SPARK_CLASSPATH"; fi && \
4242
if ! [ -z ${SPARK_EXECUTOR_EXTRA_CLASSPATH+x} ]; then SPARK_CLASSPATH="$SPARK_EXECUTOR_EXTRA_CLASSPATH:$SPARK_CLASSPATH"; fi && \
4343
if ! [ -z ${SPARK_MOUNTED_FILES_DIR} ]; then cp -R "$SPARK_MOUNTED_FILES_DIR/." .; fi && \
44-
exec ${JAVA_HOME}/bin/java -Dspark.executor.port=$SPARK_EXECUTOR_PORT -Xms$SPARK_EXECUTOR_MEMORY -Xmx$SPARK_EXECUTOR_MEMORY -cp $SPARK_CLASSPATH org.apache.spark.executor.CoarseGrainedExecutorBackend --driver-url $SPARK_DRIVER_URL --executor-id $SPARK_EXECUTOR_ID --cores $SPARK_EXECUTOR_CORES --app-id $SPARK_APPLICATION_ID --hostname $SPARK_EXECUTOR_POD_IP
44+
exec /sbin/tini -- ${JAVA_HOME}/bin/java -Dspark.executor.port=$SPARK_EXECUTOR_PORT -Xms$SPARK_EXECUTOR_MEMORY -Xmx$SPARK_EXECUTOR_MEMORY -cp $SPARK_CLASSPATH org.apache.spark.executor.CoarseGrainedExecutorBackend --driver-url $SPARK_DRIVER_URL --executor-id $SPARK_EXECUTOR_ID --cores $SPARK_EXECUTOR_CORES --app-id $SPARK_APPLICATION_ID --hostname $SPARK_EXECUTOR_POD_IP

resource-managers/kubernetes/docker-minimal-bundle/src/main/docker/init-container/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ FROM openjdk:8-alpine
2222
# docker build -t spark-executor:latest -f dockerfiles/executor/Dockerfile .
2323

2424
RUN apk upgrade --update
25-
RUN apk add --update bash
25+
RUN apk add --update bash tini
2626
RUN mkdir -p /opt/spark
2727
RUN touch /opt/spark/RELEASE
2828

@@ -35,4 +35,4 @@ ENV SPARK_HOME /opt/spark
3535

3636
WORKDIR /opt/spark
3737

38-
ENTRYPOINT [ "bin/spark-class", "org.apache.spark.deploy.rest.kubernetes.KubernetesSparkDependencyDownloadInitContainer" ]
38+
ENTRYPOINT [ "/sbin/tini", "--", "bin/spark-class", "org.apache.spark.deploy.rest.kubernetes.KubernetesSparkDependencyDownloadInitContainer" ]

resource-managers/kubernetes/docker-minimal-bundle/src/main/docker/resource-staging-server/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ FROM openjdk:8-alpine
2222
# docker build -t spark-executor:latest -f dockerfiles/executor/Dockerfile .
2323

2424
RUN apk upgrade --update
25-
RUN apk add --update bash
25+
RUN apk add --update bash tini
2626
RUN mkdir -p /opt/spark
2727
RUN touch /opt/spark/RELEASE
2828

@@ -35,4 +35,4 @@ ENV SPARK_HOME /opt/spark
3535

3636
WORKDIR /opt/spark
3737

38-
ENTRYPOINT [ "bin/spark-class", "org.apache.spark.deploy.rest.kubernetes.ResourceStagingServer" ]
38+
ENTRYPOINT [ "/sbin/tini", "--", "bin/spark-class", "org.apache.spark.deploy.rest.kubernetes.ResourceStagingServer" ]

resource-managers/kubernetes/docker-minimal-bundle/src/main/docker/shuffle-service/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ FROM openjdk:8-alpine
2222
# docker build -t spark-shuffle:latest -f dockerfiles/shuffle/Dockerfile .
2323

2424
RUN apk upgrade --update
25-
RUN apk add --update bash
25+
RUN apk add --update bash tini
2626
RUN mkdir -p /opt/spark
2727
RUN touch /opt/spark/RELEASE
2828

@@ -36,4 +36,4 @@ ENV SPARK_HOME /opt/spark
3636

3737
WORKDIR /opt/spark
3838

39-
CMD ["/bin/sh","-c","/opt/spark/bin/spark-class org.apache.spark.deploy.ExternalShuffleService 1"]
39+
ENTRYPOINT [ "/sbin/tini", "--", "bin/spark-class", "org.apache.spark.deploy.ExternalShuffleService", "1" ]

0 commit comments

Comments
 (0)