Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Commit d4e6959

Browse files
gatorsmilecloud-fan
authored andcommitted
[MINOR][SQL] Remove Useless zipWithIndex from ResolveAliases
## What changes were proposed in this pull request? Remove useless `zipWithIndex` from `ResolveAliases `. ## How was this patch tested? The existing tests Author: gatorsmile <[email protected]> Closes apache#20009 from gatorsmile/try22.
1 parent 0609dcc commit d4e6959

File tree

1 file changed

+13
-15
lines changed
  • sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis

1 file changed

+13
-15
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -222,22 +222,20 @@ class Analyzer(
222222
*/
223223
object ResolveAliases extends Rule[LogicalPlan] {
224224
private def assignAliases(exprs: Seq[NamedExpression]) = {
225-
exprs.zipWithIndex.map {
226-
case (expr, i) =>
227-
expr.transformUp { case u @ UnresolvedAlias(child, optGenAliasFunc) =>
228-
child match {
229-
case ne: NamedExpression => ne
230-
case go @ GeneratorOuter(g: Generator) if g.resolved => MultiAlias(go, Nil)
231-
case e if !e.resolved => u
232-
case g: Generator => MultiAlias(g, Nil)
233-
case c @ Cast(ne: NamedExpression, _, _) => Alias(c, ne.name)()
234-
case e: ExtractValue => Alias(e, toPrettySQL(e))()
235-
case e if optGenAliasFunc.isDefined =>
236-
Alias(child, optGenAliasFunc.get.apply(e))()
237-
case e => Alias(e, toPrettySQL(e))()
238-
}
225+
exprs.map(_.transformUp { case u @ UnresolvedAlias(child, optGenAliasFunc) =>
226+
child match {
227+
case ne: NamedExpression => ne
228+
case go @ GeneratorOuter(g: Generator) if g.resolved => MultiAlias(go, Nil)
229+
case e if !e.resolved => u
230+
case g: Generator => MultiAlias(g, Nil)
231+
case c @ Cast(ne: NamedExpression, _, _) => Alias(c, ne.name)()
232+
case e: ExtractValue => Alias(e, toPrettySQL(e))()
233+
case e if optGenAliasFunc.isDefined =>
234+
Alias(child, optGenAliasFunc.get.apply(e))()
235+
case e => Alias(e, toPrettySQL(e))()
239236
}
240-
}.asInstanceOf[Seq[NamedExpression]]
237+
}
238+
).asInstanceOf[Seq[NamedExpression]]
241239
}
242240

243241
private def hasUnresolvedAlias(exprs: Seq[NamedExpression]) =

0 commit comments

Comments
 (0)