Attempt to better handle cases where underlying connection is closed tue to reconnectOnException flag

Author: jeanouii

activemq-jms-pool/src/main/java/org/apache/activemq/jms/pool/PooledConnectionFactory.java

@@ -129,7 +129,12 @@ public void destroyObject(ConnectionKey connectionKey, PooledObject<ConnectionPo
                     @Override
                     public boolean validateObject(ConnectionKey connectionKey, PooledObject<ConnectionPool> pooledObject) {
                         ConnectionPool connection = pooledObject.getObject();
-                        if (connection != null && connection.expiredCheck()) {
+                        if (connection == null || connection.getConnection() == null) {
+                            LOG.trace("Connection has been closed and will be destroyed: {}", connection);
+                            return false;
+                        }
+
+                        if (connection.expiredCheck()) {
                             LOG.trace("Connection has expired: {} and will be destroyed", connection);
                             return false;
                         }

activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/PooledConnectionSecurityExceptionTest.java

@@ -237,8 +237,12 @@ public void testFailoverWithInvalidCredentials() throws Exception {
 
             @Override
             public boolean isSatisified() throws Exception {
-                return connection1.getConnection() !=
-                          ((PooledConnection) pooledConnFact.createConnection("invalid", "credentials")).getConnection();
+                PooledConnection newConnection = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials");
+                try {
+                    return connection1.getConnection() != newConnection.getConnection();
+                } finally {
+                    newConnection.close();
+                }
             }
         }));