Make sure to keep trying if the first attempt to get a new connection fails

Author: jeanouii

activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/PooledConnectionSecurityExceptionTest.java

@@ -134,13 +134,15 @@ public void testFailureGetsNewConnectionOnRetry() throws Exception {
             @Override
             public boolean isSatisified() throws Exception {
                 try (final PooledConnection newConnection = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials")) {
-                    return connection1.getConnection() != newConnection.getConnection();
+                    return connection1.pool != ((PooledConnection)newConnection).pool;
+                } catch (Exception e) {
+                    return false;
                 }
             }
         }));
 
         final PooledConnection connection2 = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials");
-        assertNotSame(connection1.getConnection(), connection2.getConnection());
+        assertNotSame(connection1.pool, connection2.pool);
 
         try {
             connection2.start();
@@ -233,13 +235,15 @@ public void testFailoverWithInvalidCredentials() throws Exception {
             @Override
             public boolean isSatisified() throws Exception {
                 try (final PooledConnection newConnection = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials")) {
-                    return connection1.getConnection() != newConnection.getConnection();
+                    return connection1.pool != ((PooledConnection)newConnection).pool;
+                } catch (Exception e) {
+                    return false;
                 }
             }
         }));
 
         final PooledConnection connection2 = (PooledConnection) pooledConnFact.createConnection("invalid", "credentials");
-        assertNotSame(connection1.getConnection(), connection2.getConnection());
+        assertNotSame(connection1.pool, connection2.pool);
 
         try {
             connection2.start();
@@ -410,4 +414,4 @@ protected BrokerPlugin configureAuthorization() throws Exception {
 
         return authorizationPlugin;
     }
-}
+}