Use Playwright assertions directly instead of helper functions that fail silently

Author: vbottu

airflow-core/src/airflow/ui/tests/e2e/pages/HomePage.ts

@@ -77,20 +77,6 @@ export class HomePage extends BasePage {
     this.taskInstanceMetrics = page.getByRole("heading", { name: /task instance/i }).first();
   }
 
-  /**
-   * Check if health badges are visible
-   */
-  public async areHealthBadgesVisible(): Promise<boolean> {
-    try {
-      await this.metaDatabaseHealth.waitFor({ state: "visible", timeout: 10_000 });
-      await this.schedulerHealth.waitFor({ state: "visible", timeout: 5000 });
-
-      return true;
-    } catch {
-      return false;
-    }
-  }
-
   /**
    * Get Active DAGs count
    */
@@ -123,32 +109,6 @@ export class HomePage extends BasePage {
     }
   }
 
-  /**
-   * Check if historical metrics (recent runs) section is visible
-   */
-  public async isHistoricalMetricsSectionVisible(): Promise<boolean> {
-    try {
-      await this.dagRunMetrics.waitFor({ state: "visible", timeout: 10_000 });
-
-      return true;
-    } catch {
-      return false;
-    }
-  }
-
-  /**
-   * Check if stats section is visible
-   */
-  public async isStatsSectionVisible(): Promise<boolean> {
-    try {
-      await this.activeDagsCard.waitFor({ state: "visible", timeout: 10_000 });
-
-      return true;
-    } catch {
-      return false;
-    }
-  }
-
   /**
    * Navigate to Home/Dashboard page
    */

airflow-core/src/airflow/ui/tests/e2e/specs/home-dashboard.spec.ts

@@ -30,9 +30,8 @@ test.describe("Dashboard Metrics Display", () => {
     await homePage.navigate();
     await homePage.waitForDashboardLoad();
 
-    const isStatsVisible = await homePage.isStatsSectionVisible();
-
-    expect(isStatsVisible).toBe(true);
+    // Use Playwright assertions directly for clearer error messages
+    await expect(homePage.statsSection).toBeVisible();
 
     await expect(homePage.activeDagsCard).toBeVisible();
     const activeDagsCount = await homePage.getActiveDagsCount();
@@ -54,10 +53,8 @@ test.describe("Dashboard Metrics Display", () => {
     await homePage.navigate();
     await homePage.waitForDashboardLoad();
 
-    const areHealthBadgesVisible = await homePage.areHealthBadgesVisible();
-
-    expect(areHealthBadgesVisible).toBe(true);
-
+    // Use Playwright assertions directly for clearer error messages
+    await expect(homePage.healthSection).toBeVisible();
     await expect(homePage.metaDatabaseHealth).toBeVisible();
     await expect(homePage.schedulerHealth).toBeVisible();
     await expect(homePage.triggererHealth).toBeVisible();
@@ -103,9 +100,8 @@ test.describe("Dashboard Metrics Display", () => {
     await homePage.page.reload();
     await homePage.waitForDashboardLoad();
 
-    const isStatsVisible = await homePage.isStatsSectionVisible();
-
-    expect(isStatsVisible).toBe(true);
+    // Use Playwright assertions directly for clearer error messages
+    await expect(homePage.statsSection).toBeVisible();
 
     const reloadedActiveCount = await homePage.getActiveDagsCount();
     const reloadedRunningCount = await homePage.getRunningDagsCount();
@@ -120,10 +116,8 @@ test.describe("Dashboard Metrics Display", () => {
     await homePage.navigate();
     await homePage.waitForDashboardLoad();
 
-    const isHistoricalMetricsVisible = await homePage.isHistoricalMetricsSectionVisible();
-
-    expect(isHistoricalMetricsVisible).toBe(true);
-
+    // Use Playwright assertions directly for clearer error messages
+    await expect(homePage.historicalMetricsSection).toBeVisible();
     await expect(homePage.dagRunMetrics).toBeVisible();
     await expect(homePage.taskInstanceMetrics).toBeVisible();
   });