Sanitise password in logs while parsing connection from URI (#62180)

Co-authored-by: Stephen Bracken <email-protected>

Author: stephen-bracken

airflow-core/src/airflow/models/connection.py

@@ -226,7 +226,7 @@ def _normalize_conn_type(conn_type):
     def _parse_from_uri(self, uri: str):
         schemes_count_in_uri = uri.count("://")
         if schemes_count_in_uri > 2:
-            raise AirflowException(f"Invalid connection string: {uri}.")
+            raise AirflowException("Invalid connection string.")
         host_with_protocol = schemes_count_in_uri == 2
         uri_parts = urlsplit(uri)
         conn_type = uri_parts.scheme
@@ -235,7 +235,7 @@ def _parse_from_uri(self, uri: str):
         if host_with_protocol:
             uri_splits = rest_of_the_url.split("://", 1)
             if "@" in uri_splits[0] or ":" in uri_splits[0]:
-                raise AirflowException(f"Invalid connection string: {uri}.")
+                raise AirflowException("Invalid connection string.")
         uri_parts = urlsplit(rest_of_the_url)
         protocol = uri_parts.scheme if host_with_protocol else None
         host = _parse_netloc_to_hostname(uri_parts)

airflow-core/tests/unit/models/test_connection.py

@@ -138,7 +138,7 @@ def clear_fernet_cache(self):
                 {"param": "value"},
                 None,
             ),
-            (
+            (  # Test password sanitisation
                 "type://user:pass@protocol://host:port?param=value",
                 None,
                 None,
@@ -147,7 +147,29 @@ def clear_fernet_cache(self):
                 None,
                 None,
                 None,
-                r"Invalid connection string: type://user:pass@protocol://host:port?param=value.",
+                r"Invalid connection string.",
+            ),
+            (
+                "foo:pwd@host://://",
+                None,
+                None,
+                None,
+                None,
+                None,
+                None,
+                None,
+                r"Invalid connection string.",
+            ),
+            (
+                "type://:foo@host/://://",
+                None,
+                None,
+                None,
+                None,
+                None,
+                None,
+                None,
+                r"Invalid connection string.",
             ),
             (
                 "type://host?int_param=123&bool_param=true&float_param=1.5&str_param=some_str",