Skip to content

Commit 9941f18

Browse files
authored
Improve FastApi exclusion for Cadwyn incompatibility and link Cadwyn … (#59859)
* Improve FastApi exclusion for Cadwyn incompatibility and link Cadwyn issue Cadwyn is not compatible (yet) with FastAPI 0.128.0 - but the changes in FastAPI are deliberately breaking so there is no way we are going to support FastAPI >=0.128.0 unless there is a fix from Cadwyn (and we also need to fix generating models for task-sdk to not use private method that has been removed in FastAPI 0.128.0. Therefore, it's better to upper-bind FastAPI rather than exclude it, because there might be more versions of FastAPI released before Cadwyn gets fixed. Also the issue zmievsa/cadwyn#316 has been created, describing the root cause and suggested way how the issue could be fixed in Cadwyn and comment on the reason for upper binding was added to make sure we keep track of it. * Apply suggestion from @potiuk
1 parent 4a73545 commit 9941f18

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

airflow-core/pyproject.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,12 @@ dependencies = [
8585
"cryptography>=41.0.0,<46.0.0",
8686
"deprecated>=1.2.13",
8787
"dill>=0.2.2",
88-
"fastapi[standard-no-fastapi-cloud-cli]>=0.127.0,!=0.128.0",
88+
# Cadwyn is not compatible with FastAPI 0.128.0 due to dropping of Pydantic v1 and Cadwyn using some
89+
# internal methods dropped in FastAPI 0.128.0. Tracked in https://github.com/zmievsa/cadwyn/issues/316
90+
# We will also have to fix `task-sdk/dev/generate_task_sdk_models.py` script as we are mocking removed
91+
# _get_long_model_name method there once Cadwyn releases a new version - we should find a better way
92+
# to override long model name (if it is still needed) without relying on private methods.
93+
"fastapi[standard-no-fastapi-cloud-cli]>=0.127.0,<0.128.0",
8994
"uvicorn>=0.37.0",
9095
"starlette>=0.45.0",
9196
"httpx>=0.25.0",

0 commit comments

Comments
 (0)