Skip to content

Commit 08a1d37

Browse files
committed
fix(conformance-test): HTTPRouteQueryParamMatching
1 parent 0f29ac7 commit 08a1d37

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ GO_LDFLAGS ?= "-X=$(VERSYM)=$(VERSION) -X=$(GITSHASYM)=$(GITSHA) -X=$(BUILDOSSYM
5252
# gateway-api
5353
GATEAY_API_VERSION ?= v1.3.0
5454
## https://github.com/kubernetes-sigs/gateway-api/blob/v1.3.0/pkg/features/httproute.go
55-
SUPPORTED_EXTENDED_FEATURES = "HTTPRouteDestinationPortMatching,HTTPRouteMethodMatching,HTTPRoutePortRedirect,HTTPRouteRequestMirror,HTTPRouteSchemeRedirect,GatewayAddressEmpty,HTTPRouteResponseHeaderModification,GatewayPort8080"
55+
SUPPORTED_EXTENDED_FEATURES = "HTTPRouteDestinationPortMatching,HTTPRouteMethodMatching,HTTPRoutePortRedirect,HTTPRouteRequestMirror,HTTPRouteSchemeRedirect,GatewayAddressEmpty,HTTPRouteResponseHeaderModification,GatewayPort8080,HTTPRouteQueryParamMatching"
5656
CONFORMANCE_TEST_REPORT_OUTPUT ?= $(DIR)/apisix-ingress-controller-conformance-report.yaml
5757
## https://github.com/kubernetes-sigs/gateway-api/blob/v1.3.0/conformance/utils/suite/profiles.go
5858
CONFORMANCE_PROFILES ?= GATEWAY-HTTP,GATEWAY-GRPC

internal/adc/translator/httproute.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -732,7 +732,7 @@ func (t *Translator) translateGatewayHTTPRouteMatch(match *gatewayv1.HTTPRouteMa
732732
for _, query := range match.QueryParams {
733733
var this []adctypes.StringOrSlice
734734
this = append(this, adctypes.StringOrSlice{
735-
StrVal: "arg_" + strings.ToLower(fmt.Sprintf("%v", query.Name)),
735+
StrVal: "arg_" + fmt.Sprintf("%v", query.Name),
736736
})
737737

738738
queryType := gatewayv1.QueryParamMatchExact
@@ -771,7 +771,6 @@ func (t *Translator) translateGatewayHTTPRouteMatch(match *gatewayv1.HTTPRouteMa
771771
}
772772

773773
func HeaderMatchToVars(matchType, name, value string) ([]adctypes.StringOrSlice, error) {
774-
name = strings.ToLower(name)
775774
name = strings.ReplaceAll(name, "-", "_")
776775

777776
var this []adctypes.StringOrSlice

0 commit comments

Comments
 (0)