fix: route names with the same prefix were mistakenly deleted (#2472)

Author: AlinsRan

internal/provider/adc/cache/indexer.go

@@ -56,6 +56,12 @@ type LabelIndexer struct {
 	GetLabels func(obj any) map[string]string
 }
 
+// ref: https://pkg.go.dev/github.com/hashicorp/go-memdb#Txn.Get
+// by adding suffixes to avoid prefix matching
+func (emi *LabelIndexer) genKey(labelValues []string) []byte {
+	return []byte(strings.Join(labelValues, "/") + "\x00")
+}
+
 func (emi *LabelIndexer) FromObject(obj any) (bool, []byte, error) {
 	labels := emi.GetLabels(obj)
 	var labelValues []string
@@ -69,7 +75,7 @@ func (emi *LabelIndexer) FromObject(obj any) (bool, []byte, error) {
 		return false, nil, nil
 	}
 
-	return true, []byte(strings.Join(labelValues, "/")), nil
+	return true, emi.genKey(labelValues), nil
 }
 
 func (emi *LabelIndexer) FromArgs(args ...any) ([]byte, error) {
@@ -86,5 +92,5 @@ func (emi *LabelIndexer) FromArgs(args ...any) ([]byte, error) {
 		labelValues = append(labelValues, value)
 	}
 
-	return []byte(strings.Join(labelValues, "/")), nil
+	return emi.genKey(labelValues), nil
 }

test/e2e/apisix/route.go

@@ -356,6 +356,42 @@ spec:
 			applier.MustApplyAPIv2(types.NamespacedName{Namespace: s.Namespace(), Name: "httpbin-service-e2e-test"}, new(apiv2.ApisixUpstream), apisixUpstreamSpec1)
 			Eventually(request).WithTimeout(8 * time.Second).ProbeEvery(time.Second).Should(Equal(http.StatusOK))
 		})
+
+		It("Multiple ApisixRoute with same prefix name", func() {
+			const apisixRouteSpec = `
+apiVersion: apisix.apache.org/v2
+kind: ApisixRoute
+metadata:
+  name: %s
+spec:
+  ingressClassName: apisix
+  http:
+  - name: rule0
+    match:
+      hosts:
+      - %s
+      paths:
+      - /*
+    backends:
+    - serviceName: httpbin-service-e2e-test
+      servicePort: 80
+`
+			By("apply ApisixRoute")
+			var apisixRoute apiv2.ApisixRoute
+			for _, id := range []string{"11111", "1111", "111", "11", "1"} {
+				name := fmt.Sprintf("route-%s", id)
+				host := fmt.Sprintf("httpbin-%s", id)
+				applier.MustApplyAPIv2(types.NamespacedName{Namespace: s.Namespace(), Name: name}, &apisixRoute, fmt.Sprintf(apisixRouteSpec, name, host))
+			}
+
+			By("verify ApisixRoute works")
+			for _, id := range []string{"1", "11", "111", "1111", "11111"} {
+				host := fmt.Sprintf("httpbin-%s", id)
+				Eventually(func() int {
+					return s.NewAPISIXClient().GET("/get").WithHost(host).Expect().Raw().StatusCode
+				}).WithTimeout(8 * time.Second).ProbeEvery(time.Second).Should(Equal(http.StatusOK))
+			}
+		})
 	})
 
 	Context("Test ApisixRoute reference ApisixUpstream", func() {