Skip to content

Commit a368e28

Browse files
authored
fix(conformance-test): HTTPRouteQueryParamMatching (#2598)
1 parent f6db456 commit a368e28

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ GO_LDFLAGS ?= "-X=$(VERSYM)=$(VERSION) -X=$(GITSHASYM)=$(GITSHA) -X=$(BUILDOSSYM
5252
# gateway-api
5353
GATEAY_API_VERSION ?= v1.3.0
5454
## https://github.com/kubernetes-sigs/gateway-api/blob/v1.3.0/pkg/features/httproute.go
55-
SUPPORTED_EXTENDED_FEATURES = "HTTPRouteDestinationPortMatching,HTTPRouteMethodMatching,HTTPRoutePortRedirect,HTTPRouteRequestMirror,HTTPRouteSchemeRedirect,GatewayAddressEmpty,HTTPRouteResponseHeaderModification,GatewayPort8080,HTTPRouteHostRewrite"
55+
SUPPORTED_EXTENDED_FEATURES = "HTTPRouteDestinationPortMatching,HTTPRouteMethodMatching,HTTPRoutePortRedirect,HTTPRouteRequestMirror,HTTPRouteSchemeRedirect,GatewayAddressEmpty,HTTPRouteResponseHeaderModification,GatewayPort8080,HTTPRouteHostRewrite,HTTPRouteQueryParamMatching"
5656
CONFORMANCE_TEST_REPORT_OUTPUT ?= $(DIR)/apisix-ingress-controller-conformance-report.yaml
5757
## https://github.com/kubernetes-sigs/gateway-api/blob/v1.3.0/conformance/utils/suite/profiles.go
5858
CONFORMANCE_PROFILES ?= GATEWAY-HTTP,GATEWAY-GRPC

internal/adc/translator/httproute.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -734,7 +734,7 @@ func (t *Translator) translateGatewayHTTPRouteMatch(match *gatewayv1.HTTPRouteMa
734734
for _, query := range match.QueryParams {
735735
var this []adctypes.StringOrSlice
736736
this = append(this, adctypes.StringOrSlice{
737-
StrVal: "arg_" + strings.ToLower(fmt.Sprintf("%v", query.Name)),
737+
StrVal: "arg_" + fmt.Sprintf("%v", query.Name),
738738
})
739739

740740
queryType := gatewayv1.QueryParamMatchExact
@@ -773,7 +773,6 @@ func (t *Translator) translateGatewayHTTPRouteMatch(match *gatewayv1.HTTPRouteMa
773773
}
774774

775775
func HeaderMatchToVars(matchType, name, value string) ([]adctypes.StringOrSlice, error) {
776-
name = strings.ToLower(name)
777776
name = strings.ReplaceAll(name, "-", "_")
778777

779778
var this []adctypes.StringOrSlice

0 commit comments

Comments
 (0)