fix: responseHeaderModifier fails to synchronize #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzp2010
approved these changes
Sep 5, 2025
ronething
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
In the type definition, they are mandatory. If only add is set, the other two will be empty arrays and empty objects, respectively:
apisix-ingress-controller/api/adc/types.go
Lines 637 to 641 in ec8624b
When only one of add, set, or remove is defined, schema validation (e.g., minItems=1) cannot be guaranteed by the data plane.
https://github.com/apache/apisix/blob/9e34661e7edb57fa76a215333b92c6d086e80076/apisix/plugins/response-rewrite.lua#L59-L80
Pre-submission checklist: