-
Notifications
You must be signed in to change notification settings - Fork 179
Open
Description
What happened?
It looks like __COUNTER__ has been promoted from a compiler extension (that happened to be enabled by default?) to a C2y feature, and now clang is issuing warnings for using it (because now it's an actual future feature) - not sure how best to handle this (this is rather annoying behavior). I don't want to enable C2y in general, maybe we silence this warning?
Stack Trace
In file included from /adbc/c/driver/common/utils.c:18:
In file included from /adbc/c/driver/common/utils.h:26:
/adbc/c/vendor/nanoarrow/../nanoarrow/nanoarrow.h:2595:3: error: '__COUNTER__' is a C2y extension [-Werror,-Wc2y-extensions]
2595 | NANOARROW_RETURN_NOT_OK(ArrowBufferReserve(buffer, size_bytes));
| ^
/adbc/c/vendor/nanoarrow/../nanoarrow/nanoarrow.h:308:69: note: expanded from macro 'NANOARROW_RETURN_NOT_OK'
308 | _NANOARROW_RETURN_NOT_OK_IMPL(_NANOARROW_MAKE_NAME(errno_status_, __COUNTER__), EXPR)
| ^
How can we reproduce the bug?
No response
Environment/Setup
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type: bugSomething isn't workingSomething isn't working