Skip to content

Commit 47face2

Browse files
chore: Bump github.com/substrait-io/substrait-go/v7 from 7.2.0 to 7.2.2 (#612)
Bumps [github.com/substrait-io/substrait-go/v7](https://github.com/substrait-io/substrait-go) from 7.2.0 to 7.2.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/substrait-io/substrait-go/releases">github.com/substrait-io/substrait-go/v7's releases</a>.</em></p> <blockquote> <h1>v7.2.2 (2025-12-14)</h1> <h3>Bug fixes</h3> <ul> <li>correctly handle differing <code>any</code> types in fn invocation (<a href="https://redirect.github.com/substrait-io/substrait-go/issues/180">#180</a>) (<a href="https://github.com/substrait-io/substrait-go/commit/579861e290363a09304916963ddc61a8e7873698">579861e</a>)</li> </ul> <h1>v7.2.1 (2025-12-07)</h1> <h3>Bug fixes</h3> <ul> <li>correctly handle UDT literals with structure (<a href="https://redirect.github.com/substrait-io/substrait-go/issues/171">#171</a>) (<a href="https://github.com/substrait-io/substrait-go/commit/940d2ba467a0870a973b43be466593eeeadfd387">940d2ba</a>)</li> <li>correctly validate misaligned any1, any2, etc. (<a href="https://redirect.github.com/substrait-io/substrait-go/issues/173">#173</a>) (<a href="https://github.com/substrait-io/substrait-go/commit/9897edaf90a281a97b8c76fc9f25dfda0d84cead">9897eda</a>) <blockquote> <p>bump to substrait 0.78.1</p> </blockquote> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/substrait-io/substrait-go/commit/579861e290363a09304916963ddc61a8e7873698"><code>579861e</code></a> fix: correctly handle differing <code>any</code> types in fn invocation (<a href="https://redirect.github.com/substrait-io/substrait-go/issues/180">#180</a>)</li> <li><a href="https://github.com/substrait-io/substrait-go/commit/940d2ba467a0870a973b43be466593eeeadfd387"><code>940d2ba</code></a> fix: correctly handle UDT literals with structure (<a href="https://redirect.github.com/substrait-io/substrait-go/issues/171">#171</a>)</li> <li><a href="https://github.com/substrait-io/substrait-go/commit/9897edaf90a281a97b8c76fc9f25dfda0d84cead"><code>9897eda</code></a> fix: correctly validate misaligned any1, any2, etc. (<a href="https://redirect.github.com/substrait-io/substrait-go/issues/173">#173</a>)</li> <li><a href="https://github.com/substrait-io/substrait-go/commit/e1b6c47d5bf699b2edf42a20bf9f6210433b575e"><code>e1b6c47</code></a> Update UserDefinedType reference only if it is ParameterizedUserDefinedType (...</li> <li>See full diff in <a href="https://github.com/substrait-io/substrait-go/compare/v7.2.0...v7.2.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/substrait-io/substrait-go/v7&package-manager=go_modules&previous-version=7.2.0&new-version=7.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Topol <zotthewizard@gmail.com>
1 parent bb9d77a commit 47face2

File tree

3 files changed

+39
-18
lines changed

3 files changed

+39
-18
lines changed

arrow/compute/exprs/exec_test.go

Lines changed: 30 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import (
3636
"github.com/stretchr/testify/require"
3737
"github.com/substrait-io/substrait-go/v7/expr"
3838
"github.com/substrait-io/substrait-go/v7/types"
39+
proto "github.com/substrait-io/substrait-protobuf/go/substraitpb"
3940
)
4041

4142
var (
@@ -138,8 +139,6 @@ func TestComparisons(t *testing.T) {
138139
one = scalar.MakeScalar(int32(1))
139140
two = scalar.MakeScalar(int32(2))
140141

141-
str = scalar.MakeScalar("hello")
142-
bin = scalar.MakeScalar([]byte("hello"))
143142
exampleUUID = uuid.MustParse("102cb62f-e6f8-4eb0-9973-d9b012ff0967")
144143
exampleUUID2 = uuid.MustParse("c1b0d8e0-0b0e-4b1e-9b0a-0e0b0d0c0a0b")
145144
uuidStorage, _ = scalar.MakeScalarParam(exampleUUID[:],
@@ -201,8 +200,12 @@ func TestComparisons(t *testing.T) {
201200
expect(t, "greater", one, zero, true)
202201
expect(t, "greater", one, two, false)
203202

204-
expect(t, "equal", str, bin, true)
205-
expect(t, "equal", bin, str, true)
203+
// Note: Direct comparison between string and binary types is not supported
204+
// in substrait-go v7.2.2+ due to stricter type parameter validation.
205+
// Previously these comparisons were allowed but are now correctly rejected
206+
// as 'equal(any1, any1)' requires both arguments to be the same type.
207+
// expect(t, "equal", str, bin, true)
208+
// expect(t, "equal", bin, str, true)
206209

207210
expect(t, "equal", uuidScalar, uuidScalar, true)
208211
expect(t, "equal", uuidScalar, uuidScalar2, false)
@@ -515,7 +518,15 @@ func Test_Types(t *testing.T) {
515518
v, err := arrow.Time64FromString("11:00:00.000000", arrow.Nanosecond)
516519
rq.NoError(err, "Failed to create Time64 value")
517520

518-
return expr.NewPrimitiveLiteral(types.Time(v), true)
521+
pt := &types.PrecisionTime{
522+
Precision: int32(arrow.Nanosecond) * 3,
523+
Value: int64(v),
524+
}
525+
526+
lit, err := expr.NewLiteral(pt, true)
527+
rq.NoError(err, "Failed to create literal")
528+
529+
return lit
519530
},
520531
},
521532
{
@@ -578,10 +589,20 @@ func Test_Types(t *testing.T) {
578589
return array.NewRecordBatch(schema, []arrow.Array{b.NewArray()}, 1)
579590
},
580591
val: func(rq *require.Assertions) expr.Literal {
581-
v, err := arrow.TimestampFromString("2021-01-01T11:00:00.000000Z", arrow.Microsecond)
592+
v, err := arrow.TimestampFromString("2021-01-01T11:00:00.000000Z", arrow.Nanosecond)
582593
rq.NoError(err, "Failed to create Timestamp value")
583594

584-
return expr.NewPrimitiveLiteral(types.Timestamp(v), true)
595+
pts := &types.PrecisionTimestamp{
596+
PrecisionTimestamp: &proto.Expression_Literal_PrecisionTimestamp{
597+
Precision: int32(arrow.Nanosecond) * 3,
598+
Value: int64(v),
599+
},
600+
}
601+
602+
lit, err := expr.NewLiteral(pts, true)
603+
rq.NoError(err, "Failed to create literal")
604+
605+
return lit
585606
},
586607
},
587608
{
@@ -607,12 +628,12 @@ func Test_Types(t *testing.T) {
607628
return array.NewRecordBatch(schema, []arrow.Array{b.NewArray()}, 1)
608629
},
609630
val: func(rq *require.Assertions) expr.Literal {
610-
v, p, s, err := expr.DecimalStringToBytes("456.7890123456")
631+
v, _, s, err := expr.DecimalStringToBytes("456.7890123456")
611632
rq.NoError(err, "Failed to convert decimal string to bytes")
612633

613634
lit, err := expr.NewLiteral(&types.Decimal{
614635
Value: v[:16],
615-
Precision: p,
636+
Precision: 38,
616637
Scale: s,
617638
}, true)
618639
rq.NoError(err, "Failed to create Decimal128 literal")

go.mod

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ require (
3737
github.com/pterm/pterm v0.12.82
3838
github.com/stoewer/go-strcase v1.3.1
3939
github.com/stretchr/testify v1.11.1
40-
github.com/substrait-io/substrait-go/v7 v7.2.0
40+
github.com/substrait-io/substrait-go/v7 v7.2.2
4141
github.com/tidwall/sjson v1.2.5
4242
github.com/zeebo/xxh3 v1.0.2
4343
golang.org/x/exp v0.0.0-20250408133849-7e4ce0ab07d0
@@ -78,8 +78,8 @@ require (
7878
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
7979
github.com/rivo/uniseg v0.4.7 // indirect
8080
github.com/stretchr/objx v0.5.2 // indirect
81-
github.com/substrait-io/substrait v0.75.0 // indirect
82-
github.com/substrait-io/substrait-protobuf/go v0.75.0 // indirect
81+
github.com/substrait-io/substrait v0.78.1 // indirect
82+
github.com/substrait-io/substrait-protobuf/go v0.78.1 // indirect
8383
github.com/tidwall/gjson v1.14.2 // indirect
8484
github.com/tidwall/match v1.1.1 // indirect
8585
github.com/tidwall/pretty v1.2.0 // indirect

go.sum

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,12 @@ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO
152152
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
153153
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
154154
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
155-
github.com/substrait-io/substrait v0.75.0 h1:26l61irh5kQBLeDUcgDLnm+p4s2dJloHU6PPK0RAiB0=
156-
github.com/substrait-io/substrait v0.75.0/go.mod h1:MPFNw6sToJgpD5Z2rj0rQrdP/Oq8HG7Z2t3CAEHtkHw=
157-
github.com/substrait-io/substrait-go/v7 v7.2.0 h1:49QFXeydO8OZyedzWOwHG0fG4BcXXlOwsbMalPwGWpA=
158-
github.com/substrait-io/substrait-go/v7 v7.2.0/go.mod h1:4GZ6c+UaojOGEG4ynyHrDFFmWGCVtbKdfzp6LXWdHmc=
159-
github.com/substrait-io/substrait-protobuf/go v0.75.0 h1:6SjuEESDB8oOhdQMPMGb4uy0tyZOYt1EBwS/Wcr61fs=
160-
github.com/substrait-io/substrait-protobuf/go v0.75.0/go.mod h1:hn+Szm1NmZZc91FwWK9EXD/lmuGBSRTJ5IvHhlG1YnQ=
155+
github.com/substrait-io/substrait v0.78.1 h1:Dsn+kvFQdC2k/2XRVE2+aD88WNbE4miWed2AZTtkBoQ=
156+
github.com/substrait-io/substrait v0.78.1/go.mod h1:MPFNw6sToJgpD5Z2rj0rQrdP/Oq8HG7Z2t3CAEHtkHw=
157+
github.com/substrait-io/substrait-go/v7 v7.2.2 h1:cp51u9ikUW6YjKZSV3tu6Pxeu48pkfcraYR9yG06chY=
158+
github.com/substrait-io/substrait-go/v7 v7.2.2/go.mod h1:FVQ38NeDorflB3ogd8F9tjh9S1y8RDwwfSFm24/u9HY=
159+
github.com/substrait-io/substrait-protobuf/go v0.78.1 h1:3MeQQ3DVN+KVILeMBw1z9pmLmQW9NmRiaVrgNZIwGP8=
160+
github.com/substrait-io/substrait-protobuf/go v0.78.1/go.mod h1:hn+Szm1NmZZc91FwWK9EXD/lmuGBSRTJ5IvHhlG1YnQ=
161161
github.com/tidwall/gjson v1.14.2 h1:6BBkirS0rAHjumnjHF6qgy5d2YAJ1TLIaFE2lzfOLqo=
162162
github.com/tidwall/gjson v1.14.2/go.mod h1:/wbyibRr2FHMks5tjHJ5F8dMZh3AcwJEMf5vlfC0lxk=
163163
github.com/tidwall/match v1.1.1 h1:+Ho715JplO36QYgwN9PGYNhgZvoUSc9X2c80KVTi+GA=

0 commit comments

Comments
 (0)