Skip to content

chore: Drop executable file bit of source files#274

Merged
zeroshade merged 1 commit intoapache:mainfrom
jas4711:chmod-x-source-files
Feb 11, 2025
Merged

chore: Drop executable file bit of source files#274
zeroshade merged 1 commit intoapache:mainfrom
jas4711:chmod-x-source-files

Conversation

@jas4711
Copy link
Contributor

@jas4711 jas4711 commented Feb 11, 2025

Hello. I'm packaging this project for Debian.

Our linter noticed that a bunch of source code files are marked as executable in the source repository. I don't think this is a good idea, and it is done inconsistency, so I suspect it is leftover somehow. How about the attached patch? Generated like this:

chmod -x $(find . -type f -executable|grep -v -e ^./.git -e ^./ci -e ^./dev)

/Simon

@jas4711 jas4711 requested a review from zeroshade as a code owner February 11, 2025 17:35
@zeroshade zeroshade changed the title Drop executable file bit of source files chore: Drop executable file bit of source files Feb 11, 2025
@zeroshade
Copy link
Member

Thanks for this @jas4711! This makes sense, there's no need for the .go/.c/.s/.h files to be executable.

Could you link to the packaging of this that you're doing for debian? It would be fantastic to add a link on the README indicating how it can be installed on debian/ubuntu etc.

@jas4711
Copy link
Contributor Author

jas4711 commented Feb 11, 2025

Thanks for quick reponse and review. My work is tracked here:

https://bugs.debian.org/1095753
https://salsa.debian.org/go-team/packages/golang-github-apache-arrow-go

Note that this has not yet been accepted formally into Debian, but I hope it will eventually will. I think it is safest to just assume this doesn't exist until it is formally accepted, and then all there is to it should be apt-get install golang-github-apache-arrow-go-dev like any other golang library.

@zeroshade
Copy link
Member

@jas4711 sounds good. Once it is (hopefully) formally accepted, I hope you'll file a PR to add a link to the README 😄

@zeroshade zeroshade merged commit 969722d into apache:main Feb 11, 2025
22 of 23 checks passed
@jas4711
Copy link
Contributor Author

jas4711 commented Feb 11, 2025

Thank you! I expect approval to take at least a month, the formal process is fairly slow, so don't hold your breath :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants