fix(arrow/cdata): Handle errors to prevent panic #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
changed the title
zeroshade
requested changes
Dec 19, 2025
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Looks good, can you add a test for this please?
zeroshade
approved these changes
Dec 22, 2025
Member
|
Thanks! Assuming no issues in CI i'll merge this |
Member
|
Looks like you have some test failures here |
Author
|
@zeroshade please review it |
Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
Signed-off-by: Cai Zhang <[email protected]>
Author
|
I have resubmitted the code based on the error messages, and the tests passed successfully on my local mechine. |
Member
|
@xiaocai2333 looks like there's a memory leak found by the leak sanitizer that needs to be addressed. I can poke at it tomorrow if you need help tracking it down. Specifically, the 48 bytes leaks are likely ArrowSchema objects that aren't getting freed (probably children in a nested test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes: #613
What changes are included in this PR?
Return error correctly.
Are these changes tested?
Yes
Are there any user-facing changes?
No