Skip to content

Commit 4169b62

Browse files
Override methods in composite producers
1 parent 4266ee6 commit 4169b62

File tree

4 files changed

+75
-5
lines changed

4 files changed

+75
-5
lines changed

adapter/avro/src/main/java/org/apache/arrow/adapter/avro/producers/AvroArraysProducer.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,28 @@ public void produce(Encoder encoder) throws IOException {
5656
currentIndex++;
5757
}
5858

59+
@Override
60+
public void skipNull() {
61+
delegate.skipNull();
62+
super.skipNull();
63+
}
64+
65+
@Override
66+
public void setPosition(int index) {
67+
delegate.setPosition(index);
68+
super.setPosition(index);
69+
}
70+
5971
@Override
6072
@SuppressWarnings("unchecked")
6173
public boolean resetValueVector(ListVector vector) {
6274
((Producer<FieldVector>) delegate).resetValueVector(vector.getDataVector());
6375
return super.resetValueVector(vector);
6476
}
77+
78+
@Override
79+
public void close() throws Exception {
80+
delegate.close();
81+
super.close();
82+
}
6583
}

adapter/avro/src/main/java/org/apache/arrow/adapter/avro/producers/AvroMapProducer.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,28 @@ public void produce(Encoder encoder) throws IOException {
5555
currentIndex++;
5656
}
5757

58+
@Override
59+
public void skipNull() {
60+
delegate.skipNull();
61+
super.skipNull();
62+
}
63+
64+
@Override
65+
public void setPosition(int index) {
66+
delegate.setPosition(index);
67+
super.setPosition(index);
68+
}
69+
5870
@Override
5971
@SuppressWarnings("unchecked")
6072
public boolean resetValueVector(MapVector vector) {
6173
((Producer<FieldVector>) delegate).resetValueVector(vector.getDataVector());
6274
return super.resetValueVector(vector);
6375
}
76+
77+
@Override
78+
public void close() throws Exception {
79+
delegate.close();
80+
super.close();
81+
}
6482
}

adapter/avro/src/main/java/org/apache/arrow/adapter/avro/producers/AvroNullableProducer.java

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,15 @@ public void produce(Encoder encoder) throws IOException {
4747
}
4848

4949
@Override
50-
public void close() throws Exception {
51-
delegate.close();
50+
public void skipNull() {
51+
delegate.skipNull();
52+
super.skipNull();
53+
}
54+
55+
@Override
56+
public void setPosition(int index) {
57+
delegate.setPosition(index);
58+
super.setPosition(index);
5259
}
5360

5461
@Override
@@ -60,4 +67,9 @@ public boolean resetValueVector(T vector) {
6067
public T getVector() {
6168
return delegate.getVector();
6269
}
70+
71+
@Override
72+
public void close() throws Exception {
73+
delegate.close();
74+
}
6375
}

adapter/avro/src/main/java/org/apache/arrow/adapter/avro/producers/AvroStructProducer.java

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,22 +40,44 @@ public AvroStructProducer(StructVector vector, Producer<? extends FieldVector>[]
4040
@Override
4141
public void produce(Encoder encoder) throws IOException {
4242

43-
for (Producer<? extends FieldVector> delegate : delegates) {
43+
for (Producer<?> delegate : delegates) {
4444
delegate.produce(encoder);
4545
}
4646

4747
currentIndex++;
4848
}
4949

50+
@Override
51+
public void skipNull() {
52+
for (Producer<?> delegate : delegates) {
53+
delegate.skipNull();
54+
}
55+
super.skipNull();
56+
}
57+
58+
@Override
59+
public void setPosition(int index) {
60+
for (Producer<?> delegate : delegates) {
61+
delegate.setPosition(index);
62+
}
63+
super.setPosition(index);
64+
}
65+
5066
@Override
5167
@SuppressWarnings("unchecked")
5268
public boolean resetValueVector(StructVector vector) {
53-
5469
for (int i = 0; i < delegates.length; i++) {
5570
Producer<FieldVector> delegate = (Producer<FieldVector>) delegates[i];
5671
delegate.resetValueVector(vector.getChildrenFromFields().get(i));
5772
}
58-
5973
return super.resetValueVector(vector);
6074
}
75+
76+
@Override
77+
public void close() throws Exception {
78+
for (Producer<?> delegate : delegates) {
79+
delegate.close();
80+
}
81+
super.close();
82+
}
6183
}

0 commit comments

Comments
 (0)