Move ExtensionFactory to TransferPair

Author: jhrotko

vector/src/main/codegen/templates/DenseUnionVector.java

@@ -707,6 +707,11 @@ public ValueVector getTo() {
     public void copyValueSafe(int from, int to) {
       this.to.copyFrom(from, to, DenseUnionVector.this);
     }
+
+    @Override
+    public void copyValueSafe(int from, int to, ExtensionTypeWriterFactory writerFactory) {
+      this.to.copyFrom(from, to, DenseUnionVector.this, writerFactory);
+    }
   }
 
   @Override

vector/src/main/codegen/templates/UnionVector.java

@@ -620,6 +620,11 @@ public ValueVector getTo() {
     public void copyValueSafe(int from, int to) {
       this.to.copyFrom(from, to, UnionVector.this);
     }
+
+    @Override
+    public void copyValueSafe(int from, int to, ExtensionTypeWriterFactory writerFactory) {
+      this.to.copyFrom(from, to, UnionVector.this, writerFactory);
+    }
   }
 
   @Override

vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java

@@ -30,7 +30,6 @@
 import org.apache.arrow.memory.util.hash.ArrowBufHasher;
 import org.apache.arrow.util.Preconditions;
 import org.apache.arrow.vector.compare.VectorVisitor;
-import org.apache.arrow.vector.complex.impl.ExtensionTypeWriterFactory;
 import org.apache.arrow.vector.ipc.message.ArrowFieldNode;
 import org.apache.arrow.vector.types.pojo.Field;
 import org.apache.arrow.vector.util.CallBack;
@@ -902,10 +901,4 @@ public int hashCode(int index, ArrowBufHasher hasher) {
   public <OUT, IN> OUT accept(VectorVisitor<OUT, IN> visitor, IN value) {
     return visitor.visit(this, value);
   }
-
-  @Override
-  public TransferPair makeTransferPair(
-      ValueVector target, ExtensionTypeWriterFactory writerFactory) {
-    throw new UnsupportedOperationException();
-  }
 }

vector/src/main/java/org/apache/arrow/vector/BaseValueVector.java

@@ -384,10 +384,4 @@ protected void allocateValidityBuffer(long byteSizeTarget) {
     validityBuffer.readerIndex(0);
     validityBuffer.setZero(0, validityBuffer.capacity());
   }
-
-  @Override
-  public TransferPair makeTransferPair(
-      ValueVector target, ExtensionTypeWriterFactory writerFactory) {
-    throw new UnsupportedOperationException();
-  }
 }

vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java

@@ -31,7 +31,6 @@
 import org.apache.arrow.memory.util.hash.ArrowBufHasher;
 import org.apache.arrow.util.Preconditions;
 import org.apache.arrow.vector.compare.VectorVisitor;
-import org.apache.arrow.vector.complex.impl.ExtensionTypeWriterFactory;
 import org.apache.arrow.vector.ipc.message.ArrowFieldNode;
 import org.apache.arrow.vector.types.pojo.Field;
 import org.apache.arrow.vector.util.CallBack;
@@ -1444,10 +1443,4 @@ public <OUT, IN> OUT accept(VectorVisitor<OUT, IN> visitor, IN value) {
   public final int getEndOffset(int index) {
     return offsetBuffer.getInt((long) (index + 1) * OFFSET_WIDTH);
   }
-
-  @Override
-  public TransferPair makeTransferPair(
-      ValueVector target, ExtensionTypeWriterFactory writerFactory) {
-    throw new UnsupportedOperationException();
-  }
 }

vector/src/main/java/org/apache/arrow/vector/BigIntVector.java

@@ -21,6 +21,7 @@
 import org.apache.arrow.memory.ArrowBuf;
 import org.apache.arrow.memory.BufferAllocator;
 import org.apache.arrow.vector.complex.impl.BigIntReaderImpl;
+import org.apache.arrow.vector.complex.impl.ExtensionTypeWriterFactory;
 import org.apache.arrow.vector.complex.reader.FieldReader;
 import org.apache.arrow.vector.holders.BigIntHolder;
 import org.apache.arrow.vector.holders.NullableBigIntHolder;
@@ -350,5 +351,11 @@ public void splitAndTransfer(int startIndex, int length) {
     public void copyValueSafe(int fromIndex, int toIndex) {
       to.copyFromSafe(fromIndex, toIndex, BigIntVector.this);
     }
+
+    @Override
+    public void copyValueSafe(
+        int fromIndex, int toIndex, ExtensionTypeWriterFactory writerFactory) {
+      copyValueSafe(fromIndex, toIndex);
+    }
   }
 }

vector/src/main/java/org/apache/arrow/vector/BitVector.java

@@ -25,6 +25,7 @@
 import org.apache.arrow.memory.util.hash.ArrowBufHasher;
 import org.apache.arrow.util.Preconditions;
 import org.apache.arrow.vector.complex.impl.BitReaderImpl;
+import org.apache.arrow.vector.complex.impl.ExtensionTypeWriterFactory;
 import org.apache.arrow.vector.complex.reader.FieldReader;
 import org.apache.arrow.vector.holders.BitHolder;
 import org.apache.arrow.vector.holders.NullableBitHolder;
@@ -592,5 +593,11 @@ public void splitAndTransfer(int startIndex, int length) {
     public void copyValueSafe(int fromIndex, int toIndex) {
       to.copyFromSafe(fromIndex, toIndex, BitVector.this);
     }
+
+    @Override
+    public void copyValueSafe(
+        int fromIndex, int toIndex, ExtensionTypeWriterFactory writerFactory) {
+      copyValueSafe(fromIndex, toIndex);
+    }
   }
 }

vector/src/main/java/org/apache/arrow/vector/DateDayVector.java

@@ -21,6 +21,7 @@
 import org.apache.arrow.memory.ArrowBuf;
 import org.apache.arrow.memory.BufferAllocator;
 import org.apache.arrow.vector.complex.impl.DateDayReaderImpl;
+import org.apache.arrow.vector.complex.impl.ExtensionTypeWriterFactory;
 import org.apache.arrow.vector.complex.reader.FieldReader;
 import org.apache.arrow.vector.holders.DateDayHolder;
 import org.apache.arrow.vector.holders.NullableDateDayHolder;
@@ -336,5 +337,11 @@ public void splitAndTransfer(int startIndex, int length) {
     public void copyValueSafe(int fromIndex, int toIndex) {
       to.copyFromSafe(fromIndex, toIndex, DateDayVector.this);
     }
+
+    @Override
+    public void copyValueSafe(
+        int fromIndex, int toIndex, ExtensionTypeWriterFactory writerFactory) {
+      copyValueSafe(fromIndex, toIndex);
+    }
   }
 }

vector/src/main/java/org/apache/arrow/vector/DateMilliVector.java

@@ -22,6 +22,7 @@
 import org.apache.arrow.memory.ArrowBuf;
 import org.apache.arrow.memory.BufferAllocator;
 import org.apache.arrow.vector.complex.impl.DateMilliReaderImpl;
+import org.apache.arrow.vector.complex.impl.ExtensionTypeWriterFactory;
 import org.apache.arrow.vector.complex.reader.FieldReader;
 import org.apache.arrow.vector.holders.DateMilliHolder;
 import org.apache.arrow.vector.holders.NullableDateMilliHolder;
@@ -338,5 +339,11 @@ public void splitAndTransfer(int startIndex, int length) {
     public void copyValueSafe(int fromIndex, int toIndex) {
       to.copyFromSafe(fromIndex, toIndex, DateMilliVector.this);
     }
+
+    @Override
+    public void copyValueSafe(
+        int fromIndex, int toIndex, ExtensionTypeWriterFactory writerFactory) {
+      copyValueSafe(fromIndex, toIndex);
+    }
   }
 }

vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java

@@ -24,6 +24,7 @@
 import org.apache.arrow.memory.BufferAllocator;
 import org.apache.arrow.memory.util.MemoryUtil;
 import org.apache.arrow.vector.complex.impl.Decimal256ReaderImpl;
+import org.apache.arrow.vector.complex.impl.ExtensionTypeWriterFactory;
 import org.apache.arrow.vector.complex.reader.FieldReader;
 import org.apache.arrow.vector.holders.Decimal256Holder;
 import org.apache.arrow.vector.holders.NullableDecimal256Holder;
@@ -601,5 +602,11 @@ public void splitAndTransfer(int startIndex, int length) {
     public void copyValueSafe(int fromIndex, int toIndex) {
       to.copyFromSafe(fromIndex, toIndex, Decimal256Vector.this);
     }
+
+    @Override
+    public void copyValueSafe(
+        int fromIndex, int toIndex, ExtensionTypeWriterFactory writerFactory) {
+      copyValueSafe(fromIndex, toIndex);
+    }
   }
 }