Skip to content

Commit 23d253c

Browse files
nalimilanquinnjclaude
authored
Bump CategoricalArrays to 1.0 in tests (#583)
This should fix test failures from #556. --------- Co-authored-by: Jacob Quinn <quinn.jacobd@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 3847f7c commit 23d253c

File tree

4 files changed

+26
-3
lines changed

4 files changed

+26
-3
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ jobs:
115115
- uses: julia-actions/julia-buildpkg@v1.6
116116
with:
117117
project: ${{ matrix.pkg.dir }}
118+
- name: Dev local ArrowTypes for Arrow.jl tests
119+
if: matrix.pkg.name == 'Arrow.jl'
120+
shell: julia --project=. {0}
121+
run: |
122+
using Pkg
123+
Pkg.develop(PackageSpec(path="src/ArrowTypes"))
118124
- uses: julia-actions/julia-runtest@v1
119125
env:
120126
JULIA_NUM_THREADS: ${{ matrix.nthreads }}

Project.toml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
# Licensed to the Apache Software Foundation (ASF) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The ASF licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
117
name = "Arrow"
218
uuid = "69666777-d1a9-59fb-9406-91d4454c9d45"
319
authors = ["quinnj <quinn.jacobd@gmail.com>"]

dev/release/verify_rc.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,8 @@ test_source_distribution() {
186186
pushd src/ArrowTypes
187187
julia --project -e 'import Pkg; Pkg.build(); Pkg.test()'
188188
popd
189-
julia --project -e 'import Pkg; Pkg.build(); Pkg.test()'
189+
# Dev local ArrowTypes to use the version from this release, not from registry
190+
julia --project -e 'import Pkg; Pkg.develop(path="src/ArrowTypes"); Pkg.build(); Pkg.test()'
190191
}
191192

192193
VERIFY_SUCCESS=no

test/Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ TestSetExtensions = "98d24dd4-01ad-11ea-1b02-c9a08f80db04"
3636
UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
3737

3838
[compat]
39-
ArrowTypes = "2.2.2"
40-
CategoricalArrays = "0.10"
39+
ArrowTypes = "2.3"
40+
CategoricalArrays = "1"
4141
DataAPI = "1"
4242
DataFrames = "1"
4343
FilePathsBase = "0.9"

0 commit comments

Comments
 (0)