Skip to content

Commit 8680f6d

Browse files
authored
chore(dev/benchmarks): Add 0.5.0 release to benchmark run + enable build with against refacotred CMake (#516)
After #511 there is a slightly different way to build the nanoarrow with IPC support (required by benchmarks).
1 parent 784325b commit 8680f6d

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

dev/benchmarks/CMakeLists.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ fetchcontent_declare(benchmark
5353
fetchcontent_makeavailable(benchmark)
5454

5555
if(IS_DIRECTORY "${NANOARROW_BENCHMARK_SOURCE_URL}")
56+
# In nanoarrow >= 0.6.0, optional features use NANOARROW_XXX=ON instead
57+
# of being packaged as separate projects.
58+
set(NANOARROW_IPC
59+
ON
60+
CACHE INTERNAL "")
5661
fetchcontent_declare(nanoarrow SOURCE_DIR "${NANOARROW_BENCHMARK_SOURCE_URL}")
57-
fetchcontent_declare(nanoarrow_ipc
58-
SOURCE_DIR
59-
"${NANOARROW_BENCHMARK_SOURCE_URL}/extensions/nanoarrow_ipc")
60-
6162
fetchcontent_makeavailable(nanoarrow)
62-
fetchcontent_makeavailable(nanoarrow_ipc)
6363
elseif(NOT "${NANOARROW_BENCHMARK_SOURCE_URL}" STREQUAL "")
6464
fetchcontent_declare(nanoarrow URL "${NANOARROW_BENCHMARK_SOURCE_URL}")
6565
fetchcontent_declare(nanoarrow_ipc URL "${NANOARROW_BENCHMARK_SOURCE_URL}"

dev/benchmarks/CMakePresets.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,17 @@
2525
"NANOARROW_BENCHMARK_SOURCE_URL": "${sourceDir}/../.."
2626
}
2727
},
28+
{
29+
"name": "v0.5.0",
30+
"displayName": "v0.5.0",
31+
"description": "Uses the nanoarrow C sources the 0.5.0 release.",
32+
"inherits": [
33+
"base"
34+
],
35+
"cacheVariables": {
36+
"NANOARROW_BENCHMARK_SOURCE_URL": "https://github.com/apache/arrow-nanoarrow/archive/refs/tags/apache-arrow-nanoarrow-0.5.0.zip"
37+
}
38+
},
2839
{
2940
"name": "v0.4.0",
3041
"displayName": "v0.4.0",

0 commit comments

Comments
 (0)