Skip to content

Commit c413d69

Browse files
authored
chore(python): Skip buffer write lock test on PyPy (#480)
...apparently my local PyPy test was not sufficient to ensure that all the tests pass on PyPy. This seems to be specific to the `memoryview()` (not C extensions that properly release the buffer).
1 parent fbd699f commit c413d69

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

python/tests/test_c_buffer.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -238,10 +238,8 @@ def test_c_buffer_builder_buffer_protocol():
238238

239239
mv[builder.size_bytes] = ord("k")
240240

241-
if platform.python_implementation() == "PyPy" and platform.python_version_tuple()[
242-
:2
243-
] == ("3", "8"):
244-
pytest.skip("memoryview() release is not guaranteed on PyPy 3.8")
241+
if platform.python_implementation() == "PyPy":
242+
pytest.skip("memoryview() release is not guaranteed on PyPy")
245243

246244
builder.advance(1)
247245
assert bytes(builder.finish()) == b"k"

0 commit comments

Comments
 (0)