Skip to content

Conversation

@paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented May 9, 2024

This PR adds the nanoarrow_vctr, which is an R translation of the Python Array class in nanoarrow's Python bindings. This is implemented like an R factor() in the sense that under the hood it is a sequence of integers (0:(array$length - 1) at the beginning) with attributes that give those integers context.

This is implemented in such a way that it is "tacked on" to the existing conversions. The existing conversions do need a refactoring ( #392 ), but that is a heavy change for this point in the release cycle.

The only change needed to the existing conversion was a slight refactor of the "consume array stream" code that correctly gave each array in the stream its own R object to manage its lifecycle (before each array was "materialized" and then immediately released because no previous conversion code required an ArrowArray to live beyond the conversion.

The motivation for this change is converting GeoArrow extension types. In the geoarrow package, we implement an efficient conversion from a stream of arrays to various types of R-spatial objects (e.g., sf); however, we really don't want to invoke the default conversion for those types because they have awful performance (e.g., the multipolygon would be a list(list(list(data.frame))))) and there's no need to invoke that number of R object conversions between the initial state (an arrow array) and the final state (an sfc column). The nanoarrow_vctr allows something like:

df <- convert_array(some_array_containing_a_geoarrow_col)
st_as_sfc(df$geometry)  # or s2::as_s2_geography(df$geometry), or something else

A side-effect of this change is that we have an escape hatch for conversions that are lossy or contain types with no R equivalent.

A quick demo:

library(nanoarrow)

arrays <- lapply(
  list(1:5, 6:10, 11:13),
  as_nanoarrow_array
)

# A vctr can be created from any stream
(vctr <- as_nanoarrow_vctr(basic_array_stream(arrays)))
#> <nanoarrow_vctr int32[13]>
#>  [1]  1  2  3  4  5  6  7  8  9 10 11 12 13

# Under the hood this is something like a factor() where levels are
# a list of arrays with cached offsets. This is like an Arrow ChunkedArray
str(vctr)
#> <nanoarrow_vctr int32[13]>
#> List of 3
#>  $ :<nanoarrow_array int32[5]>
#>   ..$ length    : int 5
#>   ..$ null_count: int 0
#>   ..$ offset    : int 0
#>   ..$ buffers   :List of 2
#>   .. ..$ :<nanoarrow_buffer validity<bool>[0][0 b]> ``
#>   .. ..$ :<nanoarrow_buffer data<int32>[5][20 b]> `1 2 3 4 5`
#>   ..$ dictionary: NULL
#>   ..$ children  : list()
#>  $ :<nanoarrow_array int32[5]>
#>   ..$ length    : int 5
#>   ..$ null_count: int 0
#>   ..$ offset    : int 0
#>   ..$ buffers   :List of 2
#>   .. ..$ :<nanoarrow_buffer validity<bool>[0][0 b]> ``
#>   .. ..$ :<nanoarrow_buffer data<int32>[5][20 b]> `6 7 8 9 10`
#>   ..$ dictionary: NULL
#>   ..$ children  : list()
#>  $ :<nanoarrow_array int32[3]>
#>   ..$ length    : int 3
#>   ..$ null_count: int 0
#>   ..$ offset    : int 0
#>   ..$ buffers   :List of 2
#>   .. ..$ :<nanoarrow_buffer validity<bool>[0][0 b]> ``
#>   .. ..$ :<nanoarrow_buffer data<int32>[3][12 b]> `11 12 13`
#>   ..$ dictionary: NULL
#>   ..$ children  : list()

# vctrs can be sliced:
head(vctr)
#> <nanoarrow_vctr int32[6]>
#> [1] 1 2 3 4 5 6

# ...and can live in a data.frame
head(tibble::tibble(x = vctr))
#> # A tibble: 6 × 1
#>   x         
#>   <nnrrw_vc>
#> 1 1         
#> 2 2         
#> 3 3         
#> 4 4         
#> 5 5         
#> 6 6

# They can be used as zero-copy conversion targets
array <- as_nanoarrow_array(1:5)
convert_array(array, nanoarrow_vctr())
#> <nanoarrow_vctr int32[5]>
#> [1] 1 2 3 4 5

# ...also works in a nested ptype
array <- as_nanoarrow_array(data.frame(x = 1:5))
convert_array(array, tibble::tibble(x = nanoarrow_vctr()))
#> # A tibble: 5 × 1
#>   x         
#>   <nnrrw_vc>
#> 1 1         
#> 2 2         
#> 3 3         
#> 4 4         
#> 5 5

# For nested list output, it will give a slice of the original array for
# each list item
array <- as_nanoarrow_array(
  list(1:5, 6:10, NULL, 11:13),
  schema = na_list(na_int32())
)

(lst_of <- convert_array(array, vctrs::list_of(nanoarrow_vctr())))
#> <list_of<nanoarrow_vctr>[4]>
#> [[1]]
#> <nanoarrow_vctr int32[5]>
#> [1] 1 2 3 4 5
#> 
#> [[2]]
#> <nanoarrow_vctr int32[5]>
#> [1]  6  7  8  9 10
#> 
#> [[3]]
#> NULL
#> 
#> [[4]]
#> <nanoarrow_vctr int32[3]>
#> [1] 11 12 13
for (i in seq_along(lst_of)) {
  array <- attr(lst_of[[i]], "chunks")[[1]]
  cat(sprintf("offset: %d, length: %d\n", array$offset, array$length))
}
#> offset: 0, length: 5
#> offset: 5, length: 5
#> offset: 10, length: 3

Created on 2024-05-10 with reprex v2.1.0

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.20280% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.09%. Comparing base (9935713) to head (6aefdd2).
Report is 39 commits behind head on main.

Files Patch % Lines
r/R/vctr.R 96.29% 5 Missing ⚠️
r/src/convert_array_stream.c 91.30% 2 Missing ⚠️
r/src/materialize.c 98.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
+ Coverage   88.76%   89.09%   +0.32%     
==========================================
  Files          82       89       +7     
  Lines       14633    15958    +1325     
==========================================
+ Hits        12989    14217    +1228     
- Misses       1644     1741      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robinlovelace
Copy link

Amazing work, great to see these changes rolling in in real time!

@paleolimbot paleolimbot force-pushed the r-convert-chunked-finish branch from 34122dd to 8596a0a Compare May 15, 2024 17:26
@paleolimbot paleolimbot merged commit 1db7f90 into apache:main May 15, 2024
@paleolimbot paleolimbot deleted the r-convert-chunked-finish branch May 15, 2024 18:21
@paleolimbot paleolimbot added this to the nanoarrow 0.5.0 milestone May 22, 2024
paleolimbot added a commit to geoarrow/geoarrow-r that referenced this pull request May 27, 2024
GeoArrow was the wrong place for this class...it's much better in
nanoarrow! See apache/arrow-nanoarrow#461 for
the implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants