Skip to content

Commit 3931179

Browse files
authored
chore: Protect main branch with required reviews (#9547)
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #NNN. # Rationale for this change Currently any user with `write` access can merge the PR without review. Good practice to get at least 1 review before the merge <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
1 parent c214c3c commit 3931179

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.asf.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ github:
4646
strict: true
4747
# don't require any jobs to pass
4848
contexts: []
49+
required_pull_request_reviews:
50+
required_approving_review_count: 1
4951
pull_requests:
5052
# enable updating head branches of pull requests
5153
allow_update_branch: true

0 commit comments

Comments
 (0)