Skip to content

Commit 9fa2d38

Browse files
committed
Remove "mixed_arrays.json" as the reader can't actually handle
"scalar-to-array promotion", and adjust tests.
1 parent 0b306dc commit 9fa2d38

File tree

5 files changed

+8
-12
lines changed

5 files changed

+8
-12
lines changed

arrow-json/src/reader/schema.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ mod infer;
4343
/// use std::io::BufReader;
4444
/// use arrow_json::reader::infer_json_schema_from_seekable;
4545
///
46-
/// let file = File::open("test/data/mixed_arrays.json").unwrap();
46+
/// let file = File::open("test/data/arrays.json").unwrap();
4747
/// // file's cursor's offset at 0
4848
/// let mut reader = BufReader::new(file);
4949
/// let inferred_schema = infer_json_schema_from_seekable(&mut reader, None).unwrap();
@@ -89,7 +89,7 @@ pub fn infer_json_schema_from_seekable<R: BufRead + Seek>(
8989
/// use flate2::read::GzDecoder;
9090
/// use arrow_json::reader::infer_json_schema;
9191
///
92-
/// let mut file = File::open("test/data/mixed_arrays.json.gz").unwrap();
92+
/// let mut file = File::open("test/data/arrays.json.gz").unwrap();
9393
///
9494
/// // file's cursor's offset at 0
9595
/// let mut reader = BufReader::new(GzDecoder::new(&file));
@@ -158,21 +158,21 @@ mod tests {
158158
Field::new("a", DataType::Int64, true),
159159
Field::new("b", list_type_of(DataType::Float64), true),
160160
Field::new("c", list_type_of(DataType::Boolean), true),
161-
Field::new("d", list_type_of(DataType::Utf8), true),
161+
Field::new("d", DataType::Utf8, true),
162162
]);
163163

164-
let mut reader = BufReader::new(File::open("test/data/mixed_arrays.json").unwrap());
164+
let mut reader = BufReader::new(File::open("test/data/arrays.json").unwrap());
165165
let (inferred_schema, n_rows) = infer_json_schema_from_seekable(&mut reader, None).unwrap();
166166

167167
assert_eq!(inferred_schema, schema);
168-
assert_eq!(n_rows, 4);
168+
assert_eq!(n_rows, 3);
169169

170-
let file = File::open("test/data/mixed_arrays.json.gz").unwrap();
170+
let file = File::open("test/data/arrays.json.gz").unwrap();
171171
let mut reader = BufReader::new(GzDecoder::new(&file));
172172
let (inferred_schema, n_rows) = infer_json_schema(&mut reader, None).unwrap();
173173

174174
assert_eq!(inferred_schema, schema);
175-
assert_eq!(n_rows, 4);
175+
assert_eq!(n_rows, 3);
176176
}
177177

178178
#[test]

arrow-json/src/reader/value_iter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ use serde_json::Value;
3030
/// use arrow_json::reader::ValueIter;
3131
///
3232
/// let mut reader =
33-
/// BufReader::new(File::open("test/data/mixed_arrays.json").unwrap());
33+
/// BufReader::new(File::open("test/data/arrays.json").unwrap());
3434
/// let mut value_reader = ValueIter::new(&mut reader, None);
3535
/// for value in value_reader {
3636
/// println!("JSON value: {}", value.unwrap());
133 Bytes
Binary file not shown.

arrow-json/test/data/mixed_arrays.json

Lines changed: 0 additions & 4 deletions
This file was deleted.
-141 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)