chore: Use tempfile to replace hand-written utils functions (#8147)

# Which issue does this PR close?

- Closes #8143

# Rationale for this change

Code Cleanup

# What changes are included in this PR?

Use tempfile to replace hand-written utils functions

# Are these changes tested?

tested in CI.

# Are there any user-facing changes?

No

Signed-off-by: Xuanwo <[email protected]>

Author: Xuanwo

arrow-avro/src/writer/mod.rs

@@ -195,9 +195,10 @@ mod tests {
     use crate::test_util::arrow_test_data;
     use arrow_array::{ArrayRef, BinaryArray, Int32Array, RecordBatch, StringArray};
     use arrow_schema::{DataType, Field, Schema};
-    use std::fs::{remove_file, File};
+    use std::fs::File;
     use std::io::BufReader;
     use std::sync::Arc;
+    use tempfile::NamedTempFile;
 
     fn make_schema() -> Schema {
         Schema::new(vec![
@@ -220,16 +221,6 @@ mod tests {
         haystack.windows(needle.len()).any(|w| w == needle)
     }
 
-    fn unique_temp_path(prefix: &str) -> std::path::PathBuf {
-        let mut p = std::env::temp_dir();
-        let nanos = std::time::SystemTime::now()
-            .duration_since(std::time::UNIX_EPOCH)
-            .unwrap()
-            .as_nanos();
-        p.push(format!("{}_{}_{}.avro", prefix, std::process::id(), nanos));
-        p
-    }
-
     #[test]
     fn test_ocf_writer_generates_header_and_sync() -> Result<(), ArrowError> {
         let batch = make_batch();
@@ -315,7 +306,8 @@ mod tests {
             let input_batches = reader.collect::<Result<Vec<_>, _>>()?;
             let original =
                 arrow::compute::concat_batches(&schema, &input_batches).expect("concat input");
-            let out_path = unique_temp_path("arrow_avro_roundtrip");
+            let tmp = NamedTempFile::new().expect("create temp file");
+            let out_path = tmp.into_temp_path();
             let out_file = File::create(&out_path).expect("create temp avro");
             let mut writer = AvroWriter::new(out_file, original.schema().as_ref().clone())?;
             if rel.contains(".snappy.") {
@@ -343,7 +335,6 @@ mod tests {
                 "Round-trip batch mismatch for file: {}",
                 rel
             );
-            let _ = remove_file(&out_path);
         }
         Ok(())
     }