Skip to content

Commit f248768

Browse files
committed
[FIX] fix merge conflict issues
1 parent 939d4c4 commit f248768

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

parquet-variant/src/encoder/variant_to_json.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ use base64::{Engine as _, engine::general_purpose};
2222
use serde_json::Value;
2323
use std::io::Write;
2424

25-
use crate::variant::{Variant, VariantArray, VariantObject};
25+
use crate::variant::{Variant, VariantList, VariantObject};
2626

2727
/// Converts a Variant to JSON and writes it to the provided buffer
2828
///
@@ -126,7 +126,7 @@ pub fn variant_to_json<W: Write>(
126126
Variant::Object(obj) => {
127127
convert_object_to_json(json_buffer, obj)?;
128128
}
129-
Variant::Array(arr) => {
129+
Variant::List(arr) => {
130130
convert_array_to_json(json_buffer, arr)?;
131131
}
132132
}
@@ -166,7 +166,7 @@ fn convert_object_to_json<W: Write>(
166166
/// Convert array elements to JSON
167167
fn convert_array_to_json<W: Write>(
168168
buffer: &mut W,
169-
arr: &VariantArray,
169+
arr: &VariantList,
170170
) -> Result<(), ArrowError> {
171171
write!(buffer, "[")?;
172172

@@ -298,7 +298,7 @@ pub fn variant_to_json_value(variant: &Variant) -> Result<Value, ArrowError> {
298298

299299
Ok(Value::Object(map))
300300
}
301-
Variant::Array(arr) => {
301+
Variant::List(arr) => {
302302
let mut vec = Vec::new();
303303
let len = arr.len();
304304

parquet-variant/src/variant.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -415,14 +415,8 @@ impl<'m, 'v> VariantObject<'m, 'v> {
415415
}
416416

417417
pub fn values(&self) -> Result<impl Iterator<Item = Variant<'m, 'v>>, ArrowError> {
418-
let len = self.len();
419-
let mut values = Vec::new();
420-
421-
for i in 0..len {
422-
let element = self.get(i)?;
423-
values.push(element);
424-
}
425-
418+
let fields = self.parse_field_list()?;
419+
let values: Vec<_> = fields.into_iter().map(|(_, variant)| variant).collect();
426420
Ok(values.into_iter())
427421
}
428422

0 commit comments

Comments
 (0)