-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
While looking at profiles for some of the ClickBench queries, I found that almost 1% of the query time was being spent creating record batches from ArrayData,
I looked into it and i think the issue is that even though Arrays get an owned ArrayData, they still end up clone ing some things. For some arrays this isn't a big deal (a few Arc updates) for some such as StructArray and ByteViewArray it requires an extra allocation
| impl From<ArrayData> for StructArray { |
Describe the solution you'd like
I would like to avoid this overhead
Describe alternatives you've considered
I think we can directly construct the arrays from the relevant fields of ArrayData rather than having to clone them
Additional context