Some panic!s could more semantically be unimplemented! #8933
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Looks great! Thank you @abacef
arrow-array/src/array/mod.rs
Outdated
Comment on lines
827
to
840
| dt => unimplemented!("{dt}"), | ||
| }, | ||
| DataType::RunEndEncoded(run_ends_type, _) => match run_ends_type.data_type() { | ||
| DataType::Int16 => Arc::new(RunArray::<Int16Type>::from(data)) as ArrayRef, | ||
| DataType::Int32 => Arc::new(RunArray::<Int32Type>::from(data)) as ArrayRef, | ||
| DataType::Int64 => Arc::new(RunArray::<Int64Type>::from(data)) as ArrayRef, | ||
| dt => panic!("Unexpected data type for run_ends array {dt}"), | ||
| dt => unimplemented!("{dt}"), | ||
| }, | ||
| DataType::Null => Arc::new(NullArray::from(data)) as ArrayRef, | ||
| DataType::Decimal32(_, _) => Arc::new(Decimal32Array::from(data)) as ArrayRef, | ||
| DataType::Decimal64(_, _) => Arc::new(Decimal64Array::from(data)) as ArrayRef, | ||
| DataType::Decimal128(_, _) => Arc::new(Decimal128Array::from(data)) as ArrayRef, | ||
| DataType::Decimal256(_, _) => Arc::new(Decimal256Array::from(data)) as ArrayRef, | ||
| dt => panic!("Unexpected data type {dt}"), | ||
| dt => unimplemented!("{dt}"), |
Contributor
There was a problem hiding this comment.
Hi hi! Would it be possible to add a message that not only explains which data type is unimplemented, but also for which specific use case?
For example: unimplemented!("unexpected dictionary key type {dt}")
Contributor
There was a problem hiding this comment.
Oof not sure why this comment is on line 840. I was talking about lines 827 and 833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
Some
panic!conversionsThere is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Are these changes tested?
We typically require tests for all PRs in order to:
Not sure these panic test cases are covered
Are there any user-facing changes?
N/A