Skip to content

Commit 028ad13

Browse files
committed
Update destination directory for .dll files
1 parent 6feed4f commit 028ad13

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

ci/scripts/python_build.bat

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,10 @@ set CMAKE_UNITY_BUILD=ON
6565
mkdir %CPP_BUILD_DIR%
6666
pushd %CPP_BUILD_DIR%
6767

68+
@REM by default, CMake installs .lib import libs to lib and .dll libs to bin
69+
@REM delvewheel requires these to be side-by-side to properly vendor
6870
cmake ^
71+
-DCMAKE_INSTALL_BINDIR=lib ^
6972
-DARROW_ACERO=%ARROW_ACERO% ^
7073
-DARROW_BUILD_SHARED=ON ^
7174
-DARROW_BUILD_STATIC=OFF ^

cpp/cmake_modules/BuildUtils.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ function(ADD_ARROW_LIB LIB_NAME)
315315
if(ARG_INSTALL_RUNTIME_DIR)
316316
set(INSTALL_RUNTIME_DIR ${ARG_INSTALL_RUNTIME_DIR})
317317
else()
318-
set(INSTALL_RUNTIME_DIR bin)
318+
set(INSTALL_RUNTIME_DIR ${CMAKE_INSTALL_BINDIR})
319319
endif()
320320

321321
if(BUILD_SHARED)

0 commit comments

Comments
 (0)