GH-47244: [CI][Dev] Fix shellcheck errors in the ci/scripts/msys2_setup.sh

Author: hiroyuki-sato

.pre-commit-config.yaml

@@ -334,6 +334,7 @@ repos:
           ?^ci/scripts/integration_hdfs\.sh$|
           ?^ci/scripts/integration_spark\.sh$|
           ?^ci/scripts/matlab_build\.sh$|
+          ?^ci/scripts/msys2_setup\.sh$|
           ?^ci/scripts/msys2_system_clean\.sh$|
           ?^ci/scripts/msys2_system_upgrade\.sh$|
           ?^ci/scripts/nanoarrow_build\.sh$|

ci/scripts/msys2_setup.sh

@@ -24,51 +24,51 @@ target=$1
 packages=()
 case "${target}" in
   cpp|c_glib|ruby)
-    packages+=(${MINGW_PACKAGE_PREFIX}-aws-sdk-cpp)
-    packages+=(${MINGW_PACKAGE_PREFIX}-boost)
-    packages+=(${MINGW_PACKAGE_PREFIX}-brotli)
-    packages+=(${MINGW_PACKAGE_PREFIX}-bzip2)
-    packages+=(${MINGW_PACKAGE_PREFIX}-c-ares)
-    packages+=(${MINGW_PACKAGE_PREFIX}-ccache)
-    packages+=(${MINGW_PACKAGE_PREFIX}-clang)
-    packages+=(${MINGW_PACKAGE_PREFIX}-cmake)
-    packages+=(${MINGW_PACKAGE_PREFIX}-double-conversion)
-    packages+=(${MINGW_PACKAGE_PREFIX}-gflags)
-    packages+=(${MINGW_PACKAGE_PREFIX}-grpc)
-    packages+=(${MINGW_PACKAGE_PREFIX}-gtest)
-    packages+=(${MINGW_PACKAGE_PREFIX}-libutf8proc)
-    packages+=(${MINGW_PACKAGE_PREFIX}-libxml2)
-    packages+=(${MINGW_PACKAGE_PREFIX}-llvm)
-    packages+=(${MINGW_PACKAGE_PREFIX}-lz4)
-    packages+=(${MINGW_PACKAGE_PREFIX}-ninja)
-    packages+=(${MINGW_PACKAGE_PREFIX}-nlohmann-json)
-    packages+=(${MINGW_PACKAGE_PREFIX}-protobuf)
-    packages+=(${MINGW_PACKAGE_PREFIX}-rapidjson)
-    packages+=(${MINGW_PACKAGE_PREFIX}-re2)
-    packages+=(${MINGW_PACKAGE_PREFIX}-snappy)
-    packages+=(${MINGW_PACKAGE_PREFIX}-sqlite3)
-    packages+=(${MINGW_PACKAGE_PREFIX}-thrift)
-    packages+=(${MINGW_PACKAGE_PREFIX}-xsimd)
-    packages+=(${MINGW_PACKAGE_PREFIX}-uriparser)
-    packages+=(${MINGW_PACKAGE_PREFIX}-zstd)
+    packages+=("${MINGW_PACKAGE_PREFIX}-aws-sdk-cpp")
+    packages+=("${MINGW_PACKAGE_PREFIX}-boost")
+    packages+=("${MINGW_PACKAGE_PREFIX}-brotli")
+    packages+=("${MINGW_PACKAGE_PREFIX}-bzip2")
+    packages+=("${MINGW_PACKAGE_PREFIX}-c-ares")
+    packages+=("${MINGW_PACKAGE_PREFIX}-ccache")
+    packages+=("${MINGW_PACKAGE_PREFIX}-clang")
+    packages+=("${MINGW_PACKAGE_PREFIX}-cmake")
+    packages+=("${MINGW_PACKAGE_PREFIX}-double-conversion")
+    packages+=("${MINGW_PACKAGE_PREFIX}-gflags")
+    packages+=("${MINGW_PACKAGE_PREFIX}-grpc")
+    packages+=("${MINGW_PACKAGE_PREFIX}-gtest")
+    packages+=("${MINGW_PACKAGE_PREFIX}-libutf8proc")
+    packages+=("${MINGW_PACKAGE_PREFIX}-libxml2")
+    packages+=("${MINGW_PACKAGE_PREFIX}-llvm")
+    packages+=("${MINGW_PACKAGE_PREFIX}-lz4")
+    packages+=("${MINGW_PACKAGE_PREFIX}-ninja")
+    packages+=("${MINGW_PACKAGE_PREFIX}-nlohmann-json")
+    packages+=("${MINGW_PACKAGE_PREFIX}-protobuf")
+    packages+=("${MINGW_PACKAGE_PREFIX}-rapidjson")
+    packages+=("${MINGW_PACKAGE_PREFIX}-re2")
+    packages+=("${MINGW_PACKAGE_PREFIX}-snappy")
+    packages+=("${MINGW_PACKAGE_PREFIX}-sqlite3")
+    packages+=("${MINGW_PACKAGE_PREFIX}-thrift")
+    packages+=("${MINGW_PACKAGE_PREFIX}-xsimd")
+    packages+=("${MINGW_PACKAGE_PREFIX}-uriparser")
+    packages+=("${MINGW_PACKAGE_PREFIX}-zstd")
 
     if [ "${target}" != "ruby" ]; then
       # We don't update the exiting packages for Ruby because
       # RubyInstaller for Windows bundles some DLLs such as libffi,
       # OpenSSL and zlib separately. They should be ABI compatible
       # with packages installed by MSYS2. If we specify packages
       # explicitly here, the existing packages may be updated.
-      packages+=(${MINGW_PACKAGE_PREFIX}-openssl)
-      packages+=(${MINGW_PACKAGE_PREFIX}-zlib)
+      packages+=("${MINGW_PACKAGE_PREFIX}-openssl")
+      packages+=("${MINGW_PACKAGE_PREFIX}-zlib")
     fi
   ;;
 esac
 
 case "${target}" in
   c_glib|ruby)
-    packages+=(${MINGW_PACKAGE_PREFIX}-gobject-introspection)
-    packages+=(${MINGW_PACKAGE_PREFIX}-meson)
-    packages+=(${MINGW_PACKAGE_PREFIX}-vala)
+    packages+=("${MINGW_PACKAGE_PREFIX}-gobject-introspection")
+    packages+=("${MINGW_PACKAGE_PREFIX}-meson")
+    packages+=("${MINGW_PACKAGE_PREFIX}-vala")
     ;;
 esac
 
@@ -78,6 +78,7 @@ pacman \
   --sync \
   "${packages[@]}"
 
-"$(dirname $0)/ccache_setup.sh"
-echo "CCACHE_DIR=$(cygpath --absolute --windows ccache)" >> $GITHUB_ENV
-echo "PIP_CACHE_DIR=$(pip cache dir)" >> $GITHUB_ENV
+ccache_dir=$(dirname "$0")
+"${ccache_dir}/ccache_setup.sh"
+echo "CCACHE_DIR=$(cygpath --absolute --windows ccache)" >> "$GITHUB_ENV"
+echo "PIP_CACHE_DIR=$(pip cache dir)" >> "$GITHUB_ENV"