Skip to content

Commit 09c3873

Browse files
committed
Revert "Update windows test wheels dockerfiles to use MSIX"
This reverts commit 6c57b1d.
1 parent eb23207 commit 09c3873

File tree

3 files changed

+65
-20
lines changed

3 files changed

+65
-20
lines changed
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# Licensed to the Apache Software Foundation (ASF) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The ASF licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing,
12+
# software distributed under the License is distributed on an
13+
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
# KIND, either express or implied. See the License for the
15+
# specific language governing permissions and limitations
16+
# under the License.
17+
18+
# NOTE: You must update PYTHON_WHEEL_WINDOWS_TEST_IMAGE_REVISION in .env
19+
# when you update this file.
20+
21+
ARG base
22+
# https://github.com/hadolint/hadolint/wiki/DL3006
23+
# (Hadolint does not expand variables and thinks '${base}' is an untagged image)
24+
# hadolint ignore=DL3006
25+
FROM ${base}
26+
27+
ARG python=3.13
28+
29+
# hadolint ignore=SC1072
30+
RUN (if "%python%"=="3.13" setx PYTHON_VERSION "3.13.1") & \
31+
(if "%python%"=="3.14" setx PYTHON_VERSION "3.14.0")
32+
33+
SHELL ["powershell", "-NoProfile", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
34+
RUN $version = $env:PYTHON_VERSION; \
35+
$filename = 'python-' + $version + '-amd64.exe'; \
36+
$url = 'https://www.python.org/ftp/python/' + $version + '/' + $filename; \
37+
Invoke-WebRequest -Uri $url -OutFile $filename; \
38+
Start-Process -FilePath $filename -ArgumentList '/quiet', 'Include_freethreaded=1' -Wait
39+
40+
ENV PYTHON_CMD="py -${python}t"
41+
42+
SHELL ["cmd", "/S", "/C"]
43+
RUN %PYTHON_CMD% -m pip install -U pip setuptools & \
44+
if "%python%"=="3.13" ( \
45+
setx REQUIREMENTS_FILE "requirements-wheel-test-3.13t.txt" \
46+
) else ( \
47+
setx REQUIREMENTS_FILE "requirements-wheel-test.txt" \
48+
)
49+
50+
COPY python/requirements-wheel-test-3.13t.txt python/requirements-wheel-test.txt C:/arrow/python/
51+
# Cython and Pandas wheels for free-threaded are not released yet
52+
RUN %PYTHON_CMD% -m pip install \
53+
--extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple \
54+
--pre \
55+
--prefer-binary \
56+
-r C:/arrow/python/%REQUIREMENTS_FILE%
57+
58+
ENV PYTHON="${python}t"
59+
ENV PYTHON_GIL=0

ci/docker/python-wheel-windows-test-vs2022.dockerfile

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,24 +34,12 @@ RUN (if "%python%"=="3.10" setx PYTHON_VERSION "3.10.11" && setx PYTHON_CMD "py
3434
(if "%python%"=="3.13" setx PYTHON_VERSION "3.13.7" && setx PYTHON_CMD "py -3.13") & \
3535
(if "%python%"=="3.14" setx PYTHON_VERSION "3.14.0" && setx PYTHON_CMD "py -3.14")
3636

37-
# Use python_abi_tag env var to select regular or free-threaded Python
38-
ARG freethreaded=0
39-
ENV PYTHON_MODE=${freethreaded}
40-
RUN if "%PYTHON_MODE%"=="1" ( \
41-
pymanager install --version %PYTHON_VERSION% --variant freethreaded \
42-
) else ( \
43-
pymanager install --version %PYTHON_VERSION% \
44-
)
45-
4637
# hadolint ignore=DL3059
47-
RUN %PYTHON_CMD% -m pip install -U pip setuptools & \
48-
if "%python%"=="3.13" ( \
49-
setx REQUIREMENTS_FILE "requirements-wheel-test-3.13t.txt" \
50-
) else ( \
51-
setx REQUIREMENTS_FILE "requirements-wheel-test.txt" \
52-
)
38+
RUN choco install -r -y --pre --no-progress --force python --version=%PYTHON_VERSION%
39+
# hadolint ignore=DL3059
40+
RUN %PYTHON_CMD% -m pip install -U pip setuptools
5341

54-
COPY python/requirements-wheel-test-3.13t.txt python/requirements-wheel-test.txt C:/arrow/python/
55-
RUN %PYTHON_CMD% -m pip install -r C:/arrow/python/%REQUIREMENTS_FILE%
42+
COPY python/requirements-wheel-test.txt C:/arrow/python/
43+
RUN %PYTHON_CMD% -m pip install -r C:/arrow/python/requirements-wheel-test.txt
5644

5745
ENV PYTHON=$python

compose.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1445,7 +1445,6 @@ services:
14451445
args:
14461446
base: ${REPO}:python-wheel-windows-test-vs2022-base-${PYTHON_WHEEL_WINDOWS_TEST_IMAGE_REVISION}
14471447
python: ${PYTHON}
1448-
freethreaded: 0
14491448
context: .
14501449
dockerfile: ci/docker/python-wheel-windows-test-vs2022.dockerfile
14511450
volumes: *python-wheel-windows-vs2022-volumes
@@ -1457,9 +1456,8 @@ services:
14571456
args:
14581457
base: ${REPO}:python-wheel-windows-test-vs2022-base-${PYTHON_WHEEL_WINDOWS_TEST_IMAGE_REVISION}
14591458
python: ${PYTHON}
1460-
freethreaded: 1
14611459
context: .
1462-
dockerfile: ci/docker/python-wheel-windows-test-vs2022.dockerfile
1460+
dockerfile: ci/docker/python-free-threaded-wheel-windows-test-vs2022.dockerfile
14631461
volumes: *python-wheel-windows-vs2022-volumes
14641462
command: arrow\\ci\\scripts\\python_wheel_windows_test.bat
14651463

0 commit comments

Comments
 (0)