Skip to content

Commit 09f1561

Browse files
authored
GH-48376: [C++] Update GoogleTest from 1.16.0 to 1.17.0 (#48377)
### Rationale for this change This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in `ASSERT_DOUBLE_EQ` and `ASSERT_FLOAT_EQ` macros. Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). See: google/googletest@59c924b ### What changes are included in this PR? Updated `cpp/thirdparty/versions.txt`: - `ARROW_GTEST_BUILD_VERSION`: 1.16.0 -> 1.17.0 - `ARROW_GTEST_BUILD_SHA256_CHECKSUM`: Updated to match new version ### Are these changes tested? This is a dependency version update. Existing tests will validate compatibility. ### Are there any user-facing changes? No. This updates GoogleTest to version 1.17.0 to prevent potential undefined behavior in ASSERT_DOUBLE_EQ and ASSERT_FLOAT_EQ macros. Prior to version 1.17, GoogleTest used union-based type punning which is undefined behavior in C++ (reading from a union member that wasn't most recently written). This was fixed in GoogleTest commit 59c924bc. See: google/googletest@59c924b * GitHub Issue: #48376 Authored-by: Andrew Leng <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 203437b commit 09f1561

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cpp/thirdparty/versions.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ ARROW_GOOGLE_CLOUD_CPP_BUILD_VERSION=v2.22.0
7676
ARROW_GOOGLE_CLOUD_CPP_BUILD_SHA256_CHECKSUM=0c68782e57959c82e0c81def805c01460a042c1aae0c2feee905acaa2a2dc9bf
7777
ARROW_GRPC_BUILD_VERSION=v1.46.3
7878
ARROW_GRPC_BUILD_SHA256_CHECKSUM=d6cbf22cb5007af71b61c6be316a79397469c58c82a942552a62e708bce60964
79-
ARROW_GTEST_BUILD_VERSION=1.16.0
80-
ARROW_GTEST_BUILD_SHA256_CHECKSUM=78c676fc63881529bf97bf9d45948d905a66833fbfa5318ea2cd7478cb98f399
79+
ARROW_GTEST_BUILD_VERSION=1.17.0
80+
ARROW_GTEST_BUILD_SHA256_CHECKSUM=65fab701d9829d38cb77c14acdc431d2108bfdbf8979e40eb8ae567edf10b27c
8181
ARROW_JEMALLOC_BUILD_VERSION=5.3.0
8282
ARROW_JEMALLOC_BUILD_SHA256_CHECKSUM=2db82d1e7119df3e71b7640219b6dfe84789bc0537983c3b7ac4f7189aecfeaa
8383
ARROW_LZ4_BUILD_VERSION=v1.10.0

0 commit comments

Comments
 (0)