Address review comments

Author: pitrou

cpp/src/arrow/ipc/file_fuzz.cc

@@ -24,6 +24,6 @@
 
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   auto status = arrow::ipc::internal::FuzzIpcFile(data, static_cast<int64_t>(size));
-  arrow::internal::NoteFuzzStatus(status, data, static_cast<int64_t>(size));
+  arrow::internal::LogFuzzStatus(status, data, static_cast<int64_t>(size));
   return 0;
 }

cpp/src/arrow/ipc/stream_fuzz.cc

@@ -24,6 +24,6 @@
 
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   auto status = arrow::ipc::internal::FuzzIpcStream(data, static_cast<int64_t>(size));
-  arrow::internal::NoteFuzzStatus(status, data, static_cast<int64_t>(size));
+  arrow::internal::LogFuzzStatus(status, data, static_cast<int64_t>(size));
   return 0;
 }

cpp/src/arrow/memory_pool.h

@@ -310,7 +310,7 @@ class ARROW_EXPORT CappedMemoryPool : public MemoryPool {
   }
 
   MemoryPool* wrapped_;
-  int64_t bytes_allocated_limit_;
+  const int64_t bytes_allocated_limit_;
 };
 
 /// \brief Return a process-wide memory pool based on the system allocator.

cpp/src/arrow/util/fuzz_internal.cc

@@ -29,7 +29,8 @@ MemoryPool* fuzzing_memory_pool() {
   return pool.get();
 }
 
-void NoteFuzzStatus(const Status& st, const uint8_t* data, int64_t size) {
+void LogFuzzStatus(const Status& st, const uint8_t* data, int64_t size) {
+  // Most fuzz inputs will be invalid and generate errors, only log potential OOMs
   if (st.IsOutOfMemory()) {
     ARROW_LOG(WARNING) << "Fuzzing input with size=" << size
                        << " hit allocation failure: " << st.ToString();

cpp/src/arrow/util/fuzz_internal.h

@@ -32,6 +32,6 @@ constexpr int64_t kFuzzingMemoryLimit = 2200LL * 1000 * 1000;
 ARROW_EXPORT MemoryPool* fuzzing_memory_pool();
 
 // Optionally log the outcome of fuzzing an input
-ARROW_EXPORT void NoteFuzzStatus(const Status&, const uint8_t* data, int64_t size);
+ARROW_EXPORT void LogFuzzStatus(const Status&, const uint8_t* data, int64_t size);
 
 }  // namespace arrow::internal

cpp/src/parquet/arrow/fuzz.cc

@@ -21,6 +21,6 @@
 
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   auto status = parquet::arrow::internal::FuzzReader(data, static_cast<int64_t>(size));
-  arrow::internal::NoteFuzzStatus(status, data, static_cast<int64_t>(size));
+  arrow::internal::LogFuzzStatus(status, data, static_cast<int64_t>(size));
   return 0;
 }