address comments

Author: wgtmac

cpp/src/parquet/CMakeLists.txt

@@ -159,8 +159,8 @@ set(PARQUET_SRCS
     arrow/variant_internal.cc
     arrow/writer.cc
     bloom_filter.cc
-    bloom_filter_writer.cc
     bloom_filter_reader.cc
+    bloom_filter_writer.cc
     chunker_internal.cc
     column_reader.cc
     column_scanner.cc
@@ -373,8 +373,8 @@ set_source_files_properties(public_api_test.cc PROPERTIES SKIP_UNITY_BUILD_INCLU
 
 add_parquet_test(internals-test
                  SOURCES
-                 bloom_filter_test.cc
                  bloom_filter_reader_writer_test.cc
+                 bloom_filter_test.cc
                  geospatial/statistics_test.cc
                  geospatial/util_internal_test.cc
                  metadata_test.cc

cpp/src/parquet/page_index_test.cc

@@ -872,7 +872,8 @@ class PageIndexBuilderTest : public ::testing::Test {
 
   SchemaDescriptor schema_;
   std::shared_ptr<Buffer> buffer_;
-  IndexLocations column_index_location_, offset_index_location_;
+  IndexLocations column_index_location_;
+  IndexLocations offset_index_location_;
 };
 
 TEST_F(PageIndexBuilderTest, SingleRowGroup) {

cpp/src/parquet/properties.cc

@@ -108,6 +108,10 @@ void WriterProperties::Builder::CopyColumnSpecificProperties(
     if (col_props.encoding() != default_column_properties_.encoding()) {
       this->encoding(col_path, col_props.encoding());
     }
+
+    if (col_props.bloom_filter_options().has_value()) {
+      this->enable_bloom_filter(col_props.bloom_filter_options().value(), col_path);
+    }
   }
 }
 

cpp/src/parquet/properties.h

@@ -722,7 +722,7 @@ class PARQUET_EXPORT WriterProperties {
     ///
     /// \note Bloom filter is not supported for boolean columns. ParquetException will
     /// be thrown during write if the column is of boolean type.
-    Builder* enable_bloom_filter(BloomFilterOptions bloom_filter_options,
+    Builder* enable_bloom_filter(const BloomFilterOptions& bloom_filter_options,
                                  const std::string& path) {
       bloom_filter_options_[path] = bloom_filter_options;
       return this;
@@ -734,7 +734,7 @@ class PARQUET_EXPORT WriterProperties {
     ///
     /// \note Bloom filter is not supported for boolean columns. ParquetException will
     /// be thrown during write if the column is of boolean type.
-    Builder* enable_bloom_filter(BloomFilterOptions bloom_filter_options,
+    Builder* enable_bloom_filter(const BloomFilterOptions& bloom_filter_options,
                                  const std::shared_ptr<schema::ColumnPath>& path) {
       return this->enable_bloom_filter(bloom_filter_options, path->ToDotString());
     }