Skip to content

Commit 1672472

Browse files
authored
GH-47401: [C++] Remove needless Snappy patch (#47407)
### Rationale for this change Snappy 1.2.2 ships this. ### What changes are included in this PR? Remove needless the Snappy patch. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #47401 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 788f371 commit 1672472

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1411,15 +1411,6 @@ macro(build_snappy)
14111411
)
14121412
endforeach()
14131413

1414-
if(APPLE AND CMAKE_HOST_SYSTEM_VERSION VERSION_LESS 20)
1415-
# On macOS 10.13 we need to explicitly add <functional> to avoid a missing include error
1416-
# This can be removed once CRAN no longer checks on macOS 10.13
1417-
find_program(PATCH patch REQUIRED)
1418-
set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)
1419-
else()
1420-
set(SNAPPY_PATCH_COMMAND)
1421-
endif()
1422-
14231414
if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
14241415
# ignore linker flag errors, as Snappy sets
14251416
# -Werror -Wall, and Emscripten doesn't support -soname
@@ -1434,7 +1425,6 @@ macro(build_snappy)
14341425
INSTALL_DIR ${SNAPPY_PREFIX}
14351426
URL ${SNAPPY_SOURCE_URL}
14361427
URL_HASH "SHA256=${ARROW_SNAPPY_BUILD_SHA256_CHECKSUM}"
1437-
PATCH_COMMAND ${SNAPPY_PATCH_COMMAND}
14381428
CMAKE_ARGS ${SNAPPY_CMAKE_ARGS}
14391429
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
14401430

cpp/cmake_modules/snappy.diff

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)