Skip to content

Commit 1791d58

Browse files
committed
Nit updates
1 parent cc295a5 commit 1791d58

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

cpp/src/arrow/flight/sql/odbc/odbc_api.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,8 @@ SQLRETURN SQLMoreResults(SQLHSTMT stmt) {
884884
ARROW_LOG(DEBUG) << "SQLMoreResults called with stmt: " << stmt;
885885

886886
using ODBC::ODBCStatement;
887-
// Multiple result sets not supported. Return SQL_NO_DATA by default.
887+
// Multiple result sets are not supported by Arrow protocol. Return SQL_NO_DATA by
888+
// default to indicate no data is available.
888889
return ODBCStatement::ExecuteWithDiagnostics(stmt, SQL_ERROR, [=]() {
889890
ODBCStatement* statement = reinterpret_cast<ODBCStatement*>(stmt);
890891
return statement->GetMoreResults();

cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_statement.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,7 @@ bool ODBCStatement::GetData(SQLSMALLINT record_number, SQLSMALLINT c_type,
736736
}
737737

738738
SQLRETURN ODBCStatement::GetMoreResults() {
739-
// Multiple result sets are not supported.
739+
// Multiple result sets are not supported by Arrow protocol.
740740
if (current_result_) {
741741
return SQL_NO_DATA;
742742
} else {

cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ using TestTypes = ::testing::Types<StatementMockTest, StatementRemoteTest>;
3838
TYPED_TEST_SUITE(StatementTest, TestTypes);
3939

4040
TYPED_TEST(StatementTest, TestSQLMoreResultsNoData) {
41-
// Verify SQLMoreResults is stubbed to return SQL_NO_DATA
42-
41+
// Verify SQLMoreResults returns SQL_NO_DATA by default.
4342
std::wstring wsql = L"SELECT 1;";
4443
std::vector<SQLWCHAR> sql0(wsql.begin(), wsql.end());
4544

0 commit comments

Comments
 (0)