Skip to content

Commit 1a2a800

Browse files
authored
GH-47844: [CI] Fix unconditionally running extra workflows reporting when there are jobs failing (#47917)
### Rationale for this change If a job fails on the workflow the report step is currently being skipped. ### What changes are included in this PR? The unconditional `always()` check should be done on the parent workflow using `.github/workflows/report_ci.yml` not on the common one. Added also missing needed jobs before generating the report on the cpp_extra.yml (msvc-arm64 and jni-linux) ### Are these changes tested? Yes via CI I validated the job will be executed even if there are job failures. ### Are there any user-facing changes? No * GitHub Issue: #47844 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: raulcd <[email protected]>
1 parent 603901a commit 1a2a800

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

.github/workflows/cpp_extra.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,8 +327,11 @@ jobs:
327327
../minimal_build.build/arrow-example
328328
329329
report-extra-cpp:
330+
if: github.event_name == 'schedule' && always()
330331
needs:
331332
- docker
333+
- jni-linux
332334
- jni-macos
335+
- msvc-arm64
333336
uses: ./.github/workflows/report_ci.yml
334337
secrets: inherit

.github/workflows/package_linux.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,7 @@ jobs:
314314
popd
315315
316316
report-package-linux:
317+
if: github.event_name == 'schedule' && always()
317318
needs:
318319
- package
319320
uses: ./.github/workflows/report_ci.yml

.github/workflows/report_ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
# We match github.job to the name so we can pass it via context in order to be ignored on the report.
2929
# The job is still running.
3030
name: ${{ github.job }}
31-
if: github.event_name == 'schedule' && always()
3231
steps:
3332
- name: Checkout Arrow
3433
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

0 commit comments

Comments
 (0)