Commit 1f10ab4
authored
MINOR: [Release] Fix issue in post-14-vcpkg.sh causing x-add-version to fail (#47156)
### Rationale for this change
I ran into this running post-14-vcpkg.sh for the 21.0.0 release in microsoft/vcpkg#46477 (review). If "port-version" exists in vcpkg.json, x-add-version fails with,
```
warning: In arrow, 21.0.0 is a completely new version, so there should be no "port-version". Remove "port-version" and try again. To skip this check, rerun with --skip-version-format-check .
```
This looks like a warning but it's actually a hard error and will cause your upstream PR to bounce.
### What changes are included in this PR?
The script now removes the "port-version" field by default. I think the reason this worked sometimes and not others was because the field is supposed to be absent when 0 and it's usually 0 so our scripts don't need to update it.
### Are these changes tested?
Yes. Locally.
### Are there any user-facing changes?
No.
Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>1 parent 77303da commit 1f10ab4
1 file changed
+13
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
69 | 81 | | |
70 | 82 | | |
71 | 83 | | |
72 | 84 | | |
73 | 85 | | |
| 86 | + | |
74 | 87 | | |
75 | 88 | | |
76 | 89 | | |
| |||
0 commit comments