Skip to content

Commit 20d376f

Browse files
committed
Apply kou suggestion.
1 parent 2b79a61 commit 20d376f

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

cpp/src/arrow/array/statistics_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ TEST(TestArrayStatistics, NullCountExact) {
3333
ASSERT_EQ(29, std::get<int64_t>(statistics.null_count.value()));
3434
}
3535

36-
TEST(TestArrayStatistics, NullCountAprroximate) {
36+
TEST(TestArrayStatistics, NullCountApproximate) {
3737
ArrayStatistics statistics;
3838
ASSERT_FALSE(statistics.null_count.has_value());
3939
statistics.null_count = 29.0;
4040
ASSERT_TRUE(statistics.null_count.has_value());
41-
ASSERT_EQ(29.0, std::get<double>(statistics.null_count.value()));
41+
ASSERT_DOUBLE_EQ(29.0, std::get<double>(statistics.null_count.value()));
4242
}
4343

4444
TEST(TestArrayStatistics, DistinctCountExact) {

cpp/src/arrow/record_batch.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -541,14 +541,13 @@ Status EnumerateStatistics(const RecordBatch& record_batch, OnStatistics on_stat
541541
statistics.type = int64();
542542
statistics.value = std::get<int64_t>(column_statistics->null_count.value());
543543
RETURN_NOT_OK(on_statistics(statistics));
544-
statistics.start_new_column = false;
545544
} else {
546545
statistics.key = ARROW_STATISTICS_KEY_NULL_COUNT_APPROXIMATE;
547546
statistics.type = float64();
548547
statistics.value = std::get<double>(column_statistics->null_count.value());
549548
RETURN_NOT_OK(on_statistics(statistics));
550-
statistics.start_new_column = false;
551549
}
550+
statistics.start_new_column = false;
552551
}
553552

554553
if (column_statistics->distinct_count.has_value()) {

0 commit comments

Comments
 (0)