Skip to content

Commit 2e4daa4

Browse files
committed
GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh
1 parent ca21204 commit 2e4daa4

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,7 @@ repos:
342342
?^ci/scripts/python_build\.sh$|
343343
?^ci/scripts/python_sdist_build\.sh$|
344344
?^ci/scripts/python_sdist_test\.sh$|
345+
?^ci/scripts/python_test_emscripten\.sh$|
345346
?^ci/scripts/python_wheel_unix_test\.sh$|
346347
?^ci/scripts/r_build\.sh$|
347348
?^ci/scripts/r_revdepcheck\.sh$|

ci/scripts/python_test_emscripten.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,15 @@ set -ex
2525
build_dir=${1}/python
2626
pyodide_dist_dir=${2}
2727

28-
cd ${build_dir}
28+
cd "${build_dir}"
2929

3030
# note: this uses the newest wheel in dist
31+
# shellcheck disable=SC2012
3132
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
3233

3334
echo "-------------- Running emscripten tests in Node ----------------------"
34-
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
35+
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
3536

3637
echo "-------------- Running emscripten tests in Chrome --------------------"
37-
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
38+
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
3839

0 commit comments

Comments
 (0)