Skip to content

Commit 35e8136

Browse files
hiroyuki-satokou
andauthored
GH-46673: [CI][R][Docs] Accept empty INSTALL_ARGS again (#46682)
### Rationale for this change This PR fixes the bug introduced in #46527. If the environment variable `INSTALL_ARGS` doesn't set, the R command should execute, `CMD INSTALL arrow*tar.gz`. After #46527 change, It executed `CMD INSTALL '' arrow*tar.gz` ### What changes are included in this PR? Split `INSTALL_ARGS` to `R_INSTALL_ARGS` as array and use `"${R_INSTALL_ARGS[@]}"`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46673 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 4b226c9 commit 35e8136

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

ci/scripts/r_build.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ build_dir=${2}
2424

2525
: "${BUILD_DOCS_R:=OFF}"
2626

27+
R_INSTALL_ARGS=()
28+
for arg in ${INSTALL_ARGS:-}; do
29+
R_INSTALL_ARGS+=("${arg}")
30+
done
31+
2732
# https://github.com/apache/arrow/issues/41429
2833
# TODO: We want to out-of-source build. This is a workaround. We copy
2934
# all needed files to the build directory from the source directory
@@ -42,7 +47,7 @@ fi
4247
${SUDO} \
4348
env \
4449
PKG_CONFIG_PATH="${ARROW_HOME}/lib/pkgconfig:${PKG_CONFIG_PATH}" \
45-
"${R_BIN}" CMD INSTALL "${INSTALL_ARGS}" arrow*.tar.gz
50+
"${R_BIN}" CMD INSTALL "${R_INSTALL_ARGS[@]}" arrow*.tar.gz
4651

4752
if [ "${BUILD_DOCS_R}" == "ON" ]; then
4853
${R_BIN} -e "pkgdown::build_site(install = FALSE)"

0 commit comments

Comments
 (0)