GH-46645: [CI][Dev][R] Use pre-commit for styler (#46664)

### Rationale for this change

We want to migrate to pre-commit from `archery lint`.

### What changes are included in this PR?

Use pre-commit for styler against `r/`.

This also fixes styles of exiting files.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #46645

Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>

Author: kou

.pre-commit-config.yaml

@@ -201,6 +201,19 @@ repos:
         pass_filenames: false
         files: >-
           ^r/.*\.(R|Rmd)$
+  - repo: local
+    hooks:
+      - id: styler
+        alias: r
+        name: R Format
+        language: r
+        additional_dependencies:
+          - roxygen2
+          - styler
+        entry: |
+          Rscript -e "styler::style_file(commandArgs(TRUE)[1])"
+        files: >-
+          ^r/.*\.(R|Rmd)$
   - repo: https://github.com/pre-commit/mirrors-clang-format
     rev: v14.0.6
     hooks:

r/.styler_excludes.R

@@ -20,10 +20,10 @@ ARROW_R_DEV="TRUE"
 ARROW_LARGE_MEMORY_TESTS=$(ARROW_R_DEV)
 
 style:
-	R -s -e 'setwd(".."); if (requireNamespace("styler")) styler::style_file(setdiff(system("git diff --name-only | grep r/.*R$$", intern = TRUE), file.path("r", source("r/.styler_excludes.R")$$value)))'
+	pre-commit run --show-diff-on-failure --color=always styler
 
 style-all:
-	R -s -e 'styler::style_file(setdiff(dir(pattern = "R$$", recursive = TRUE), source(".styler_excludes.R")$$value))'
+	pre-commit run --show-diff-on-failure --color=always --all-files styler
 
 doc: style
 	R -s -f data-raw/docgen.R

r/Makefile

@@ -493,7 +493,7 @@ default_s3_options <- list(
 #' @examplesIf FALSE
 #' # Turn on debug logging. The following line of code should be run in a fresh
 #' # R session prior to any calls to `s3_bucket()` (or other S3 functions)
-#' Sys.setenv("ARROW_S3_LOG_LEVEL"="DEBUG")
+#' Sys.setenv("ARROW_S3_LOG_LEVEL" = "DEBUG")
 #' bucket <- s3_bucket("voltrondata-labs-datasets")
 #'
 #' @export
@@ -554,7 +554,9 @@ GcsFileSystem <- R6Class("GcsFileSystem",
       # Convert from nanoseconds to POSIXct w/ UTC tz
       if ("expiration" %in% names(out)) {
         out$expiration <- as.POSIXct(
-          out$expiration / 1000000000, origin = "1970-01-01", tz = "UTC"
+          out$expiration / 1000000000,
+          origin = "1970-01-01",
+          tz = "UTC"
         )
       }
 
@@ -609,8 +611,10 @@ GcsFileSystem$create <- function(anonymous = FALSE, retry_limit_seconds = 15, ..
     stop(
       paste(
         "Option 'expiration' must be of class POSIXct, not",
-        class(options$expiration)[[1]]),
-      call. = FALSE)
+        class(options$expiration)[[1]]
+      ),
+      call. = FALSE
+    )
   }
 
   options$retry_limit_seconds <- retry_limit_seconds

r/R/filesystem.R

@@ -140,12 +140,15 @@ process_is_running <- function(x) {
   if (tolower(Sys.info()[["sysname"]]) == "windows") {
     # Batch scripts (CMD.exe) doesn't provide a command that shows the original
     # call arguments, which we need for testbench since it's launched from Python.
-    inner_cmd <- paste("WMIC path win32_process get Commandline",
-                       sprintf("| Select-String %s", x),
-                       "| Select-String powershell.exe -NotMatch")
+    inner_cmd <- paste(
+      "WMIC path win32_process get Commandline",
+      sprintf("| Select-String %s", x),
+      "| Select-String powershell.exe -NotMatch"
+    )
     cmd <- sprintf("powershell -command \"%s\"", inner_cmd)
     tryCatch(length(system(cmd, intern = TRUE, show.output.on.console = FALSE)) > 0,
-      error = function(e) FALSE)
+      error = function(e) FALSE
+    )
   } else {
     cmd <- sprintf("ps aux | grep '%s' | grep -v grep", x)
     tryCatch(system(cmd, ignore.stdout = TRUE) == 0, error = function(e) FALSE)

r/tests/testthat/helper-skip.R

@@ -708,7 +708,6 @@ test_that("as_arrow_table() errors on data.frame with NULL names", {
 })
 
 test_that("# GH-35038 - passing in multiple arguments doesn't affect return type", {
-
   df <- data.frame(x = 1)
   out1 <- as.data.frame(arrow_table(df, name = "1"))
   out2 <- as.data.frame(arrow_table(name = "1", df))

r/tests/testthat/test-Table.R

@@ -20,7 +20,6 @@ skip_if_not_available("dataset")
 library(dplyr, warn.conflicts = FALSE)
 
 test_that("JSON dataset", {
-
   # set up JSON directory for testing
   json_dir <- make_temp_dir()
 
@@ -66,5 +65,4 @@ test_that("JSON Fragment scan options", {
   expect_equal(options$type, "json")
 
   expect_error(FragmentScanOptions$create("json", invalid_selection = TRUE), regexp = "invalid_selection")
-
 })

r/tests/testthat/test-dataset-json.R

@@ -675,7 +675,6 @@ test_that("as.factor()/dictionary_encode()", {
 })
 
 test_that("bad explicit type conversions with as.*()", {
-
   # Arrow returns lowercase "true", "false" (instead of "TRUE", "FALSE" like R)
   expect_error(
     compare_dplyr_binding(

r/tests/testthat/test-dplyr-funcs-type.R

@@ -483,7 +483,6 @@ test_that("Can read Parquet files from a URL", {
 })
 
 test_that("thrift string and container size can be specified when reading Parquet files", {
-
   tf <- tempfile()
   on.exit(unlink(tf))
   table <- arrow_table(example_data)

r/tests/testthat/test-parquet.R

@@ -330,5 +330,4 @@ test_that("schema print truncation", {
     print_schema_fields(schema(tbl), truncate = TRUE, max_fields = 0),
     regexp = "max_fields not greater than 0"
   )
-
 })